Compiz

Merge lp://staging/~feng-kylin/compiz/fix_gap_on_bottom into lp://staging/compiz/0.9.12

fix_gap_on_bottom
Merge into 0.9.12

Proposed by handsome_feng on 2016-05-13

Status:

Merged

Approved by:

Marco Trevisan (Treviño) on 2016-05-17

Approved revision:

4013

Merged at revision:

4022

Proposed branch:

lp://staging/~feng-kylin/compiz/fix_gap_on_bottom

Merge into:

lp://staging/compiz/0.9.12

Diff against target:

91 lines (+19/-4)

5 files modified

plugins/expo/expo.xml.in (+6/-0)
plugins/expo/src/expo.cpp (+3/-1)
plugins/scale/include/scale/scale.h (+1/-1)
plugins/scale/scale.xml.in (+7/-1)
plugins/scale/src/scale.cpp (+2/-1)

To merge this branch:

bzr merge lp://staging/~feng-kylin/compiz/fix_gap_on_bottom

Medium

Fix Released

Link a bug report

Reviewer	Review Type	Date Requested	Status
Marco Trevisan (Treviño)		2016-05-13	Approve on 2016-05-17
Review via email: mp+294589@code.staging.launchpad.net

Commit message

Add a YBottomOffset value when stretch maximized windows。

Description of the change

Add YBottomOffset so that you don't have an awkward gap。

Revision history for this message

Sam Spilsbury (smspillaz) wrote on 2016-05-13:

Theoretically there's nothing wrong here. I question whether it would be better to have these as internal options configured by the unityshell plugin itself as opposed to user-facing ones.

Revision history for this message

Marco Trevisan (Treviño) (3v1n0) wrote on 2016-05-14:

> Theoretically there's nothing wrong here. I question whether it would be
> better to have these as internal options configured by the unityshell plugin
> itself as opposed to user-facing ones.

Yeah, i quite agree... You could just keep the options private. Although it's not an huge problem.

Once you've fixed things as per inline comments, we're good to go.

lp://staging/~feng-kylin/compiz/fix_gap_on_bottom updated on 2016-05-16