lp://staging/~fboucault/webbrowser-app/simplify_tab_opening

Branch merges

Propose for merging

No branches dependent on this one.

Ready for review for merging into lp://staging/webbrowser-app/staging

Ubuntu Phablet Team: Pending requested 2017-02-22

Diff: 275 lines (+47/-48)

3 files modified

src/app/webbrowser/Browser.qml (+32/-27)
src/app/webbrowser/TabComponent.qml (+7/-11)
src/app/webbrowser/webbrowser-app.qml (+8/-10)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Related blueprints

1624. By Florian Boucault on 2017-02-22

Simplified tab opening, reduced number of entry points.

Moved Browser.internal.openUrlInNewTab to Browser.openUrlInNewTab and made it the main entry point to create tabs.
New Browser.openRequestInNewTab that takes in a 'request' instead of a 'url'.

TabComponent.WebViewImpl.onNewViewRequested to use Browser.openRequestInNewTab instead of BrowserWindow.addTab
Removed BrowserWindow.addTab
Browser.restoreTabState to use internal.createTabHelper instead of Browser.createTab
Removed Browser.createTab

1623. By Florian Boucault on 2017-02-22

Added corresponding AP tests

1622. By Florian Boucault on 2017-02-21

Restore focus on parent tab when closing child tab

1621. By Florian Boucault on 2017-02-21

AP test: simplified tab closing

1620. By Florian Boucault on 2017-02-20

Store and restore on startup the size of each window.

1619. By Florian Boucault on 2017-02-20

ComboBox/Drop down menus: improved UX
- added keyboard navigation
- made popover square to fit better with HTML boxes
- aligned popover with HTML box
- apply same width as HTML box whenever possible

1618. By Olivier Tilloy on 2017-02-20

Add UA overrides for google photos (desktop and mobile).

1617. By Florian Boucault on 2017-02-17

Snap: embed ubuntu-ui-extras by building it from source.

1616. By Olivier Tilloy on 2017-02-17

Merge the latest changes from trunk.

1615. By Florian Boucault on 2017-02-16

Fix issue with new tab page sometimes never being unloaded.