Merge lp://staging/~fboucault/webbrowser-app/fix_fullscreen into lp://staging/webbrowser-app/staging
Proposed by
Florian Boucault
| Status: | Merged |
|---|---|
| Merged at revision: | 1624 |
| Proposed branch: | lp://staging/~fboucault/webbrowser-app/fix_fullscreen |
| Merge into: | lp://staging/webbrowser-app/staging |
| Diff against target: |
112 lines (+37/-12) 4 files modified
src/app/BrowserWindow.qml (+5/-2) src/app/webbrowser/Browser.qml (+3/-6) src/app/webbrowser/webbrowser-app.qml (+0/-4) tests/autopilot/webbrowser_app/tests/test_fullscreen.py (+29/-0) |
| To merge this branch: | bzr merge lp://staging/~fboucault/webbrowser-app/fix_fullscreen |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Olivier Tilloy | Approve | ||
|
Review via email:
|
|||
Commit message
Fullscreen improvements:
* Simplify fullscreen: single entry point BrowserWindow.
* Do not go fullscreen if already fullscreen. Fixes case where fullscreen could not be exited anymore.
* Make chrome hide when webview is fullscreen. Remove unused property Browser.fullscreen.
Description of the change
Fullscreen improvements:
* Simplify fullscreen: single entry point BrowserWindow.
* Do not go fullscreen if already fullscreen. Fixes case where fullscreen could not be exited anymore.
* Make chrome hide when webview is fullscreen. Remove unused property Browser.fullscreen.
To post a comment you must log in.
Revision history for this message
| Olivier Tilloy (osomon) wrote | # |
Revision history for this message
| Florian Boucault (fboucault) wrote | # |
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
LGTM. Just one tiny comment inline.