Merge lp://staging/~fboucault/webbrowser-app/downloads_no_flow_interruption into lp://staging/webbrowser-app/staging
| Status: | Rejected |
|---|---|
| Rejected by: | Florian Boucault |
| Proposed branch: | lp://staging/~fboucault/webbrowser-app/downloads_no_flow_interruption |
| Merge into: | lp://staging/webbrowser-app/staging |
| Diff against target: |
951 lines (+533/-171) 12 files modified
src/app/ChromeButton.qml (+1/-0) src/app/webbrowser/Browser.qml (+14/-0) src/app/webbrowser/Chrome.qml (+1/-0) src/app/webbrowser/DownloadDelegate.qml (+4/-4) src/app/webbrowser/DownloadsList.qml (+183/-0) src/app/webbrowser/DownloadsListPopup.qml (+60/-0) src/app/webbrowser/DownloadsPage.qml (+25/-161) src/app/webbrowser/NavigationBar.qml (+21/-0) src/app/webbrowser/TabComponent.qml (+1/-1) src/app/webbrowser/assets/downloads.svg (+180/-0) tests/autopilot/webbrowser_app/emulators/browser.py (+20/-2) tests/autopilot/webbrowser_app/tests/test_downloads.py (+23/-3) |
| To merge this branch: | bzr merge lp://staging/~fboucault/webbrowser-app/downloads_no_flow_interruption |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Ubuntu Phablet Team | Pending | ||
|
Review via email:
|
|||
Commit message
Improved user experience when downloading files:
- a download button is shown instead of switching to the downloads page
- the downloads are shown in a popup when clicking the download button
- bigger, more readable font size for downloads
- added a scrollbar to the downloads list
Description of the change
Improved user experience when downloading files:
- a download button is shown instead of switching to the downloads page
- the downloads are shown in a popup when clicking the download button
- bigger, more readable font size for downloads
- added a scrollbar to the downloads list
| Florian Boucault (fboucault) wrote | # |
Unmerged revisions
- 1632. By Florian Boucault
-
Tag bug
- 1631. By Florian Boucault
-
Fixed flake8
- 1630. By Florian Boucault
-
Removed dead code
- 1629. By Florian Boucault
-
Added automated tests.
- 1628. By Florian Boucault
-
Merged from staging
- 1627. By Florian Boucault
-
Less fuzzy downloads icon
- 1626. By Florian Boucault
-
Remove possibly incorrect FIXME
- 1625. By Florian Boucault
-
Respect implicitHeight of ContentPeerPicker
- 1624. By Florian Boucault
-
New current downloads popup
- 1623. By Florian Boucault
-
Downloads list: added a scrollbar
Superseded by https:/