Merge lp://staging/~fboucault/unity-2d/opengl_plus_composite_fix into lp://staging/unity-2d/3.0
Proposed by
Florian Boucault
| Status: | Merged |
|---|---|
| Approved by: | Ricardo Salveti |
| Approved revision: | 618 |
| Merged at revision: | 617 |
| Proposed branch: | lp://staging/~fboucault/unity-2d/opengl_plus_composite_fix |
| Merge into: | lp://staging/unity-2d/3.0 |
| Diff against target: |
128 lines (+66/-23) 2 files modified
libunity-2d-private/src/unity2ddeclarativeview.cpp (+63/-23) libunity-2d-private/src/unity2ddeclarativeview.h (+3/-0) |
| To merge this branch: | bzr merge lp://staging/~fboucault/unity-2d/opengl_plus_composite_fix |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Ricardo Salveti (community) | Approve | ||
|
Review via email:
|
|||
Description of the change
[dash] Fix use of opengl rendering backend: artifacts were displayed, even more so with transparency enabled.
The cause of the issue was that the QGLWidget viewport was set on the QDeclarativeView
before having setup the QGLWidget's flags.
Implementation of Unity2dDeclarat
impacts all the components using it:
- launcher
- dash
- spread
Synchronization to VBlank has also been activated.
Set viewport update mode to QGraphicsView:
To post a comment you must log in.
Revision history for this message
| Ricardo Salveti (rsalveti) wrote | # |
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The code seems fine, but I'm unable to reproduce the original problem at least when using with the OpenGLES QT backend.
Did you only see this issue when using with normal OpenGL? I'll reproduce this on my host machine tomorrow to see if I'm at least able to reproduce the issue.