unity-2d

Merge lp://staging/~fboucault/unity-2d/dash_bigger_icons into lp://staging/unity-2d/3.0

  1. dash_bigger_icons
  2. Merge into natty
Proposed by Florian Boucault
Status: Merged
Approved by: Gerry Boland
Approved revision: 679
Merged at revision: 681
Proposed branch: lp://staging/~fboucault/unity-2d/dash_bigger_icons
Merge into: lp://staging/unity-2d/3.0
Diff against target: 54 lines (+5/-9)
2 files modified
places/HomeButton.qml (+0/-1)
places/UnityDefaultRenderer.qml (+5/-8)
To merge this branch: bzr merge lp://staging/~fboucault/unity-2d/dash_bigger_icons
Reviewer Review Type Date Requested Status
Gerry Boland (community) Approve
Review via email: mp+72540@code.staging.launchpad.net

Description of the change

[dash] Icons are now of size 64x64 instead of 48x48.

To post a comment you must log in.
Revision history for this message
Gerry Boland (gerboland) wrote :

Icons are bigger yes, but you'll need to increase the vertical size of each grid entry to allow 2 lines of text to be visible underneath each icon.

With this commit, only one line of text is visible. When you mouse over, you see the rest.

review: Needs Fixing
lp://staging/~fboucault/unity-2d/dash_bigger_icons updated
679. By Florian Boucault

Adapted layout for new icon size. Removed label underline upon keyboard focus. Reverted change on places/UnityFileInfoRenderer.qml.

Revision history for this message
Gerry Boland (gerboland) wrote :

Ok, that's better. Accepted

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches