Ubuntu UI Toolkit

Merge lp://staging/~fboucault/ubuntu-ui-toolkit/text_input_larger_selection_handle_on_trunk into lp://staging/ubuntu-ui-toolkit

text_input_larger_selection_handle_on_trunk
Merge into trunk

Proposed by Florian Boucault on 2014-11-05

Status:

Superseded

Proposed branch:

lp://staging/~fboucault/ubuntu-ui-toolkit/text_input_larger_selection_handle_on_trunk

Merge into:

lp://staging/ubuntu-ui-toolkit

Diff against target:

485 lines (+160/-108) (has conflicts)

10 files modified

modules/Ubuntu/Components/InputHandler.qml (+6/-2)
modules/Ubuntu/Components/Popups/Popover.qml (+4/-0)
modules/Ubuntu/Components/Popups/PopupBase.qml (+3/-1)
modules/Ubuntu/Components/TextArea.qml (+2/-0)
modules/Ubuntu/Components/TextCursor.qml (+120/-99)
modules/Ubuntu/Components/TextField.qml (+2/-0)
modules/Ubuntu/Components/TextInputPopover.qml (+14/-3)
modules/Ubuntu/Components/Themes/Ambiance/TextCursorStyle.qml (+0/-3)
modules/Ubuntu/Components/plugin/ucmousefilters.cpp (+1/-0)
push_to_phone.sh (+8/-0)

Text conflict in push_to_phone.sh

To merge this branch:

bzr merge lp://staging/~fboucault/ubuntu-ui-toolkit/text_input_larger_selection_handle_on_trunk

Related bugs:

Bug #1371202: [SDK] Double tap should display the contextual menu	High	Fix Released
Bug #1371206: [TOPBLOCKER] [SDK] Text selection - can't drag the handle	High	Fix Released
Bug #1375844: [SDK] Insert/Select text mode should not bar users from using other elements on screen	Medium	Fix Released
Bug #1388172: Text selection popup is sometimes on top of the selection handles	High	Fix Committed
Bug #1389654: TextField/TextArea: the touch area used for handle dragging often prevents double tap and long press from being taken into account	High	Fix Committed

Link a bug report

Reviewer	Review Type	Date Requested	Status
PS Jenkins bot	continuous-integration	2014-11-05	Needs Fixing on 2014-11-05
Ubuntu SDK team		2014-11-05	Pending
Review via email: mp+240770@code.staging.launchpad.net

This proposal supersedes a proposal from 2014-10-31.

Commit message

TextField/TextArea: make selection handle's touch area a 4 grid units wide square.

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2014-10-31: Posted in a previous version of this proposal

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-ci/1186/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2014-10-31: Posted in a previous version of this proposal

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-ci/1188/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2014-11-05:

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/ubuntu-ui-toolkit-ci/2176/rebuild

review: Needs Fixing (continuous-integration)

lp://staging/~fboucault/ubuntu-ui-toolkit/text_input_larger_selection_handle_on_trunk updated on 2014-11-11

1123. By Florian Boucault on 2014-11-07: Complete rework.
1124. By Florian Boucault on 2014-11-07: Dismiss popover on copy.
1125. By Florian Boucault on 2014-11-07: Disable select all if there is nothing to select
1126. By Florian Boucault on 2014-11-07: Reverted handle changes
1127. By Florian Boucault on 2014-11-07: Do not disable 'cut' operation when there is nothing to paste but instead when the field is read only.
1128. By Florian Boucault on 2014-11-07: Reveted changes to push_to_phone.sh
1129. By Florian Boucault on 2014-11-07: Added bug fixes tags.
1130. By Florian Boucault on 2014-11-07: Updated components.api
1131. By Florian Boucault on 2014-11-07: Sync enabled of Ubuntu.Mouse and MouseArea.
1132. By Florian Boucault on 2014-11-07: Make sure popup disappears upon drag and reappears when finished.
Make sure that when not blinking the cursor is visible.
Make sure that tapping somewhere else in the field when in insert mode closes the contextual menu.
1133. By Florian Boucault on 2014-11-07: Removed unused code.
1134. By Florian Boucault on 2014-11-07: Removed incorrect test.
1135. By Florian Boucault on 2014-11-07: More robust test_clear_selection_on_click
1136. By Florian Boucault on 2014-11-07: Fixed components::TextInputTouchTests::test_long_tap_on_selected_text
1137. By Florian Boucault on 2014-11-07: Fixed test_select_text_by_dragging_cursor_handler
1138. By Florian Boucault on 2014-11-07: Fixed test_0_drag_autosizing_textarea_drags_parent_flickable
1139. By Florian Boucault on 2014-11-10: TextInput: move clear button on top so that it takes priority over tapping on the cursor.
1140. By Florian Boucault on 2014-11-10: Added autopilot tests for select and insert modes.
1141. By Florian Boucault on 2014-11-11: TextInput: move clear button on top so that it takes priority over tapping on the cursor.
1142. By Florian Boucault on 2014-11-11: Fixed pep8 failure