Code review comment for lp://staging/~fboucault/ubuntu-ui-toolkit/simple_theming

Revision history for this message
Florian Boucault (fboucault) wrote :

> QtQuick Controls style shave "panel" component in styles, so they separate
> style properties from visuals. In this way you can change the style properties
> separately from the visuals. What do you think, shouldn't we also have this
> feature?
>

I have not found that we need to do that to get the same benefits.

> On the other hand we have the delegates specifying the styling properties as
> public properties, so a theme which is based on an other one can simply
> override the previous theme delegate and change these properties only...

Exactly.

« Back to merge proposal