Merge lp://staging/~fboucault/ubuntu-ui-toolkit/mainview_no_background_overdraw into lp://staging/ubuntu-ui-toolkit/staging
Proposed by
Florian Boucault
| Status: | Merged |
|---|---|
| Approved by: | Tim Peeters |
| Approved revision: | 1815 |
| Merged at revision: | 1816 |
| Proposed branch: | lp://staging/~fboucault/ubuntu-ui-toolkit/mainview_no_background_overdraw |
| Merge into: | lp://staging/ubuntu-ui-toolkit/staging |
| Diff against target: |
35 lines (+14/-0) 2 files modified
src/Ubuntu/Components/Themes/Ambiance/1.2/MainViewStyle.qml (+7/-0) src/Ubuntu/Components/Themes/Ambiance/1.3/MainViewStyle.qml (+7/-0) |
| To merge this branch: | bzr merge lp://staging/~fboucault/ubuntu-ui-toolkit/mainview_no_background_overdraw |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| ubuntu-sdk-build-bot | continuous-integration | Approve | |
| Zsombor Egri | Approve | ||
|
Review via email:
|
|||
Commit message
MainView: when no gradient color is needed for the background, rely on QQuickWindow's GL clear color. Lessens overdraw considerably for most apps.
To post a comment you must log in.
Revision history for this message
| ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote | # |
review:
Approve
(continuous-integration)
Revision history for this message
| ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote | # |
review:
Approve
(continuous-integration)
Revision history for this message
| ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote | # |
review:
Approve
(continuous-integration)
Revision history for this message
| ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote | # |
review:
Approve
(continuous-integration)
Revision history for this message
| ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote | # |
review:
Needs Fixing
(continuous-integration)
Revision history for this message
| ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote | # |
review:
Approve
(continuous-integration)
Revision history for this message
| ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote | # |
review:
Approve
(continuous-integration)
Revision history for this message
| ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote | # |
review:
Needs Fixing
(continuous-integration)
Revision history for this message
| ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote | # |
review:
Needs Fixing
(continuous-integration)
Revision history for this message
| Timo Jyrinki (timo-jyrinki) wrote | # |
Revision history for this message
| ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote | # |
review:
Approve
(continuous-integration)
Revision history for this message
| ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote | # |
review:
Approve
(continuous-integration)
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
PASSED: Continuous integration, rev:1813
https:/
Executed test runs:
None: https:/
Click here to trigger a rebuild:
https:/