Ubuntu UI Toolkit

Merge lp://staging/~fboucault/ubuntu-ui-toolkit/empty_text_field_long_press_handling_on_trunk into lp://staging/~bzoltan/ubuntu-ui-toolkit/trunk

  1. empty_text_field_long_press_handling_on_trunk
  2. Merge into trunk
Proposed by Florian Boucault
Status: Merged
Approved by: Zoltan Balogh
Approved revision: 1126
Merge reported by: Zoltan Balogh
Merged at revision: not available
Proposed branch: lp://staging/~fboucault/ubuntu-ui-toolkit/empty_text_field_long_press_handling_on_trunk
Merge into: lp://staging/~bzoltan/ubuntu-ui-toolkit/trunk
Diff against target: 101 lines (+40/-2)
3 files modified
modules/Ubuntu/Components/TextField.qml (+3/-0)
tests/unit_x11/tst_components/tst_textfield.qml (+1/-1)
tests/unit_x11/tst_components/tst_textinput_touch.qml (+36/-1)
To merge this branch: bzr merge lp://staging/~fboucault/ubuntu-ui-toolkit/empty_text_field_long_press_handling_on_trunk
Reviewer Review Type Date Requested Status
Zsombor Egri (community) Approve
Zoltan Balogh Pending
Review via email: mp+240849@code.staging.launchpad.net

Commit message

TextField: make sure that a long press always works even when the field is empty by ensuring the TextInput's size is set properly.

To post a comment you must log in.
Revision history for this message
Zsombor Egri (zsombi) wrote :

Was good to go.

review: Approve
lp://staging/~fboucault/ubuntu-ui-toolkit/empty_text_field_long_press_handling_on_trunk updated
1125. By Florian Boucault

More stable tests.

1126. By Florian Boucault

Removed irrelevant test.

Revision history for this message
Timo Jyrinki (timo-jyrinki) wrote :

This got released to https://launchpad.net/ubuntu-rtm/+source/ubuntu-ui-toolkit/1.1.1298+15.04.20141107.2~rtm-0ubuntu1 and merged to https://code.launchpad.net/~ubuntu-sdk-team/ubuntu-ui-toolkit/rtm manually. I don't know why this was/is targeted directly to trunk which is vivid.

Revision history for this message
Cris Dywan (kalikiana) wrote :

This has already been merged everywhere… but I can't fix the status for some reason…

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches