Ubuntu UI Toolkit

Merge lp://staging/~fboucault/ubuntu-ui-toolkit/empty_text_field_long_press_handling into lp://staging/ubuntu-ui-toolkit/staging

empty_text_field_long_press_handling
Merge into staging

Proposed by Florian Boucault on 2014-10-30

Status:

Superseded

Proposed branch:

lp://staging/~fboucault/ubuntu-ui-toolkit/empty_text_field_long_press_handling

Merge into:

lp://staging/ubuntu-ui-toolkit/staging

Diff against target:

73 lines (+33/-1)

3 files modified

modules/Ubuntu/Components/TextField.qml (+3/-0)
tests/unit_x11/tst_components/tst_textfield.qml (+1/-1)
tests/unit_x11/tst_components/tst_textinput_touch.qml (+29/-0)

To merge this branch:

bzr merge lp://staging/~fboucault/ubuntu-ui-toolkit/empty_text_field_long_press_handling

High

Fix Released

Link a bug report

Reviewer	Review Type	Date Requested	Status
Zsombor Egri		2014-10-30	Needs Fixing on 2014-11-04
PS Jenkins bot	continuous-integration		Needs Fixing on 2014-10-31
Review via email: mp+240119@code.staging.launchpad.net

This proposal has been superseded by a proposal from 2014-11-04.

Commit message

TextField: make sure that a long press always works even when the field is empty by ensuring the TextInput's size is set properly.

lp://staging/~fboucault/ubuntu-ui-toolkit/empty_text_field_long_press_handling updated on 2014-10-30

1312. By Florian Boucault on 2014-10-30: Fix alignment

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2014-10-30:

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-ci/1180/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

Zsombor Egri (zsombi) wrote on 2014-10-30:

You must adjust the unit tests to the changes.

review: Needs Fixing

lp://staging/~fboucault/ubuntu-ui-toolkit/empty_text_field_long_press_handling updated on 2014-10-31

1313. By Florian Boucault on 2014-10-31: Added unit test and fixed broken one.

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2014-10-31:

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-ci/1183/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

Zsombor Egri (zsombi) wrote on 2014-11-04:

Seems the text area doesn't obey to the long tap.

review: Needs Fixing

Unmerged revisions

1313. By Florian Boucault on 2014-10-31: Added unit test and fixed broken one.
1312. By Florian Boucault on 2014-10-30: Fix alignment
1311. By Florian Boucault on 2014-10-30: TextField: make sure that a long press always works even when the field is empty by ensuring the TextInput's size is set properly.