Code review comment for lp://staging/~fboucault/thumbnailer/new_qml_api

Qml tests not being run automatically is not a new issue. Should be fixed
separately.
Le 25 févr. 2015 07:52, "Jussi Pakkanen" <email address hidden> a
écrit :

> Review: Needs Fixing
>
> I didn't get to review the functional bits quite yet, but here are some
> simpler issues in the mean time.
>
> - the qml tests don't seem to be run
> - the bit that converts relative file names to absolute ones is duplicated
> in get_thumbnail and needs_generation, please move it to a shared function
> in an anonymous namespace
> - the name needs_generation seems a bit backwards, would it be better to
> call it is_cached instead
>
> --
> https://code.launchpad.net/~fboucault/thumbnailer/new_qml_api/+merge/250832
> You are the owner of lp:~fboucault/thumbnailer/new_qml_api.
>