qtubuntu

Merge lp://staging/~fboucault/qtubuntu/dpr_rebase_qt_5.1 into lp://staging/qtubuntu

  1. dpr_rebase_qt_5.1
  2. Merge into trunk
Proposed by Florian Boucault
Status: Work in progress
Proposed branch: lp://staging/~fboucault/qtubuntu/dpr_rebase_qt_5.1
Merge into: lp://staging/qtubuntu
Diff against target: 261 lines (+74/-17)
8 files modified
src/modules/application/input_filter_area.cc (+16/-1)
src/modules/application/input_filter_area.h (+3/-0)
src/platforms/base/input.cc (+5/-4)
src/platforms/base/window.cc (+6/-0)
src/platforms/base/window.h (+3/-0)
src/platforms/ubuntu/ubuntucommon/screen.cc (+29/-7)
src/platforms/ubuntu/ubuntucommon/screen.h (+4/-0)
src/platforms/ubuntu/ubuntucommon/window.cc (+8/-5)
To merge this branch: bzr merge lp://staging/~fboucault/qtubuntu/dpr_rebase_qt_5.1
Reviewer Review Type Date Requested Status
Unity8 CI Bot continuous-integration Needs Fixing
Daniel d'Andrada (community) Needs Information
Gerry Boland (community) Needs Fixing
PS Jenkins bot continuous-integration Approve
Loïc Molinari (community) Approve
Review via email: mp+183500@code.staging.launchpad.net

Commit message

Change is only enabled for the webbrowser app.

Rebase resolution independence on Qt's infrastructure:
- QPlatformScreen::devicePixelRatio
- QPlatformWindow::devicePixelRatio

Change is only enabled for Qt version >= 5.1

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:171
http://jenkins.qa.ubuntu.com/job/qtubuntu-ci/65/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/qtubuntu-saucy-armhf-ci/53
        deb: http://jenkins.qa.ubuntu.com/job/qtubuntu-saucy-armhf-ci/53/artifact/work/output/*zip*/output.zip

Click here to trigger a rebuild:
http://s-jenkins:8080/job/qtubuntu-ci/65/rebuild

review: Approve (continuous-integration)
Reply
lp://staging/~fboucault/qtubuntu/dpr_rebase_qt_5.1 updated
172. By Florian Boucault

Merged from trunk

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:172
http://jenkins.qa.ubuntu.com/job/qtubuntu-ci/90/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/qtubuntu-trusty-armhf-ci/1
        deb: http://jenkins.qa.ubuntu.com/job/qtubuntu-trusty-armhf-ci/1/artifact/work/output/*zip*/output.zip

Click here to trigger a rebuild:
http://10.97.0.26:8080/job/qtubuntu-ci/90/rebuild

review: Approve (continuous-integration)
Reply
Revision history for this message
Timo Jyrinki (timo-jyrinki) wrote :

I wonder if this should/could be #ifdef:d so that it would work correctly regardless of if built against Qt 5.0.2 or Qt 5.1/5.2? See eg. https://code.launchpad.net/~aacid/qtubuntu/event_dispatcher_52/+merge/194128

Reply
Revision history for this message
Timo Jyrinki (timo-jyrinki) wrote :

Ok, I may be wrong in asking for the #ifdef:s, so please ignore me if needed. I'm just interested that if a new qtubuntu is released before Qt 5.2, nothing breaks in the current images where Qt 5.0.2 is used.

< tsdgeos> Mirv: we'd need some input from Kaleo here but it seems to me the devicePixelRatio virutals are also in 5.0 so it may just work in both

Reply
lp://staging/~fboucault/qtubuntu/dpr_rebase_qt_5.1 updated
173. By Florian Boucault

Adapt to the Qt 5.2 way of creating the event dispatcher

174. By Florian Boucault

Merged trunk

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:174
http://jenkins.qa.ubuntu.com/job/qtubuntu-ci/94/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/qtubuntu-trusty-armhf-ci/5
        deb: http://jenkins.qa.ubuntu.com/job/qtubuntu-trusty-armhf-ci/5/artifact/work/output/*zip*/output.zip

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/qtubuntu-ci/94/rebuild

review: Approve (continuous-integration)
Reply
lp://staging/~fboucault/qtubuntu/dpr_rebase_qt_5.1 updated
175. By Florian Boucault

Removed spamming log.

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:175
http://jenkins.qa.ubuntu.com/job/qtubuntu-ci/95/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/qtubuntu-trusty-armhf-ci/6
        deb: http://jenkins.qa.ubuntu.com/job/qtubuntu-trusty-armhf-ci/6/artifact/work/output/*zip*/output.zip

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/qtubuntu-ci/95/rebuild

review: Approve (continuous-integration)
Reply
Revision history for this message
Albert Astals Cid (aacid) wrote :

Versions with #ifdefs available at https://code.launchpad.net/~aacid/qtubuntu/dpr_rebase_qt_5.1_with_ifdefs/+merge/196165

Reply
lp://staging/~fboucault/qtubuntu/dpr_rebase_qt_5.1 updated
176. By Florian Boucault

Merged trunk

177. By Florian Boucault

Merged conditional code from lp:~aacid/qtubuntu/dpr_rebase_qt_5.1_with_ifdefs

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:177
http://jenkins.qa.ubuntu.com/job/qtubuntu-ci/98/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/qtubuntu-trusty-armhf-ci/9
        deb: http://jenkins.qa.ubuntu.com/job/qtubuntu-trusty-armhf-ci/9/artifact/work/output/*zip*/output.zip

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/qtubuntu-ci/98/rebuild

review: Approve (continuous-integration)
Reply
lp://staging/~fboucault/qtubuntu/dpr_rebase_qt_5.1 updated
178. By Florian Boucault

Merged with trunk

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:178
http://jenkins.qa.ubuntu.com/job/qtubuntu-ci/112/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/qtubuntu-trusty-armhf-ci/23
        deb: http://jenkins.qa.ubuntu.com/job/qtubuntu-trusty-armhf-ci/23/artifact/work/output/*zip*/output.zip

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/qtubuntu-ci/112/rebuild

review: Approve (continuous-integration)
Reply
lp://staging/~fboucault/qtubuntu/dpr_rebase_qt_5.1 updated
179. By Florian Boucault

Merged from trunk.

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:179
http://jenkins.qa.ubuntu.com/job/qtubuntu-ci/118/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/qtubuntu-trusty-armhf-ci/29
        deb: http://jenkins.qa.ubuntu.com/job/qtubuntu-trusty-armhf-ci/29/artifact/work/output/*zip*/output.zip

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/qtubuntu-ci/118/rebuild

review: Approve (continuous-integration)
Reply
lp://staging/~fboucault/qtubuntu/dpr_rebase_qt_5.1 updated
180. By Florian Boucault

More concise pixel ratio management.

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:180
http://jenkins.qa.ubuntu.com/job/qtubuntu-ci/119/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/qtubuntu-trusty-armhf-ci/30
        deb: http://jenkins.qa.ubuntu.com/job/qtubuntu-trusty-armhf-ci/30/artifact/work/output/*zip*/output.zip

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/qtubuntu-ci/119/rebuild

review: Approve (continuous-integration)
Reply
lp://staging/~fboucault/qtubuntu/dpr_rebase_qt_5.1 updated
181. By Florian Boucault

ua_ui_window_properties_set_dimensions needs the geometry in actual pixels too.

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:181
http://jenkins.qa.ubuntu.com/job/qtubuntu-ci/121/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/qtubuntu-trusty-armhf-ci/32
        deb: http://jenkins.qa.ubuntu.com/job/qtubuntu-trusty-armhf-ci/32/artifact/work/output/*zip*/output.zip

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/qtubuntu-ci/121/rebuild

review: Approve (continuous-integration)
Reply
lp://staging/~fboucault/qtubuntu/dpr_rebase_qt_5.1 updated
182. By Florian Boucault

Fix InputFilterArea by adding missing coordinates conversion.

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:182
http://jenkins.qa.ubuntu.com/job/qtubuntu-ci/122/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/qtubuntu-trusty-armhf-ci/33
        deb: http://jenkins.qa.ubuntu.com/job/qtubuntu-trusty-armhf-ci/33/artifact/work/output/*zip*/output.zip

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/qtubuntu-ci/122/rebuild

review: Approve (continuous-integration)
Reply
lp://staging/~fboucault/qtubuntu/dpr_rebase_qt_5.1 updated
183. By Florian Boucault

Take into account that there might not be a window.

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:183
http://jenkins.qa.ubuntu.com/job/qtubuntu-ci/123/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/qtubuntu-trusty-armhf-ci/34/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/qtubuntu-ci/123/rebuild

review: Needs Fixing (continuous-integration)
Reply
lp://staging/~fboucault/qtubuntu/dpr_rebase_qt_5.1 updated
184. By Florian Boucault

Round width and height so that the actual dimensions are computed from the virtual ones without missing any pixel.

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:184
http://jenkins.qa.ubuntu.com/job/qtubuntu-ci/124/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/qtubuntu-trusty-armhf-ci/35/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/qtubuntu-ci/124/rebuild

review: Needs Fixing (continuous-integration)
Reply
lp://staging/~fboucault/qtubuntu/dpr_rebase_qt_5.1 updated
185. By Florian Boucault

Added forgotten ifdef.

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:185
http://jenkins.qa.ubuntu.com/job/qtubuntu-ci/125/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/qtubuntu-trusty-armhf-ci/36
        deb: http://jenkins.qa.ubuntu.com/job/qtubuntu-trusty-armhf-ci/36/artifact/work/output/*zip*/output.zip

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/qtubuntu-ci/125/rebuild

review: Approve (continuous-integration)
Reply
Revision history for this message
Loïc Molinari (loic.molinari) wrote :

Good.

review: Approve
Reply
lp://staging/~fboucault/qtubuntu/dpr_rebase_qt_5.1 updated
186. By Florian Boucault

Only activate devicePixelRatio based scaling for webbrowser-app.

187. By Florian Boucault

Also activate devicePixelRatio based scaling for webapps.

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:186
http://jenkins.qa.ubuntu.com/job/qtubuntu-ci/126/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/qtubuntu-trusty-armhf-ci/37/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/qtubuntu-ci/126/rebuild

review: Needs Fixing (continuous-integration)
Reply
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:187
http://jenkins.qa.ubuntu.com/job/qtubuntu-ci/127/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/qtubuntu-trusty-armhf-ci/38/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/qtubuntu-ci/127/rebuild

review: Needs Fixing (continuous-integration)
Reply
lp://staging/~fboucault/qtubuntu/dpr_rebase_qt_5.1 updated
188. By Florian Boucault

Missing semicolon.

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:188
http://jenkins.qa.ubuntu.com/job/qtubuntu-ci/128/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/qtubuntu-trusty-armhf-ci/39
        deb: http://jenkins.qa.ubuntu.com/job/qtubuntu-trusty-armhf-ci/39/artifact/work/output/*zip*/output.zip

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/qtubuntu-ci/128/rebuild

review: Approve (continuous-integration)
Reply
Revision history for this message
Gerry Boland (gerboland) wrote :

Hey Florian,
the surface flinger specific part of this MR can be deleted, i.e. all changes in src/modules/application

I could then take on a review.

review: Needs Fixing
Reply
Revision history for this message
Florian Boucault (fboucault) wrote :

> Hey Florian,
> the surface flinger specific part of this MR can be deleted, i.e. all changes
> in src/modules/application
>
> I could then take on a review.

Thanks but it was already reviewed and "good to go" but it depends on other non ready things.

Reply
Revision history for this message
Daniel d'Andrada (dandrader) wrote :

Time has passed and we are now way beyond Qt 5.1. So all those version checks can go away.
Is this patch still relevant today?

review: Needs Information
Reply
Revision history for this message
Unity8 CI Bot (unity8-ci-bot) wrote :

FAILED: Continuous integration, rev:188
https://unity8-jenkins.ubuntu.com/job/lp-qtubuntu-1-ci/3/
Executed test runs:

Click here to trigger a rebuild:
https://unity8-jenkins.ubuntu.com/job/lp-qtubuntu-1-ci/3/rebuild

review: Needs Fixing (continuous-integration)
Reply
Revision history for this message
Unity8 CI Bot (unity8-ci-bot) wrote :

FAILED: Continuous integration, rev:188
https://unity8-jenkins.ubuntu.com/job/lp-qtubuntu-ci/26/
Executed test runs:
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-0-fetch/1128/console

Click here to trigger a rebuild:
https://unity8-jenkins.ubuntu.com/job/lp-qtubuntu-ci/26/rebuild

review: Needs Fixing (continuous-integration)
Reply

Unmerged revisions

188. By Florian Boucault

Missing semicolon.

187. By Florian Boucault

Also activate devicePixelRatio based scaling for webapps.

186. By Florian Boucault

Only activate devicePixelRatio based scaling for webbrowser-app.

185. By Florian Boucault

Added forgotten ifdef.

184. By Florian Boucault

Round width and height so that the actual dimensions are computed from the virtual ones without missing any pixel.

183. By Florian Boucault

Take into account that there might not be a window.

182. By Florian Boucault

Fix InputFilterArea by adding missing coordinates conversion.

181. By Florian Boucault

ua_ui_window_properties_set_dimensions needs the geometry in actual pixels too.

180. By Florian Boucault

More concise pixel ratio management.

179. By Florian Boucault

Merged from trunk.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches