Merge into trunk : startup_time_return : Code : messaging-app

Status:	Merged
Merged at revision:	608
Proposed branch:	lp://staging/~fboucault/messaging-app/startup_time_return
Merge into:	lp://staging/messaging-app
Diff against target:	1169 lines (+600/-397) 12 files modified src/qml/Dialogs/NoNetworkDialog.qml (+39/-0) src/qml/EmptyStatePage.qml (+31/-0) src/qml/ListItemDemo.qml (+296/-0) src/qml/MainPage.qml (+34/-25) src/qml/Messages.qml (+5/-64) src/qml/MessagingBottomEdge.qml (+16/-10) src/qml/ParticipantsPopover.qml (+68/-0) src/qml/Scrollbar.qml (+24/-0) src/qml/SwipeItemDemo.qml (+13/-277) src/qml/ThreadDelegate.qml (+30/-6) src/qml/ThreadsSectionDelegate.qml (+43/-0) src/qml/messaging-app.qml (+1/-15)
To merge this branch:	bzr merge lp://staging/~fboucault/messaging-app/startup_time_return
Related bugs:	Link a bug report

Reviewer	Review Type	Date Requested	Status
system-apps-ci-bot	continuous-integration		Needs Fixing on 2016-10-06
Tiago Salem Herrmann (community)		2016-10-04	Needs Fixing on 2016-10-05
Review via email: mp+307547@code.staging.launchpad.net

Commit message

Various startup time improvements (1000ms on krillin):
- do not use inline Components for dialogs and popovers.
- do not use inline Components for the empty page state
- do not use inline Component for ThreadsSectionDelegate
- do not use inline Component for SwipeItemDemo
- compile and instantiate threads scrollbar asynchronously
- conversations list: use new standard ListItem instead of custom ListItemWithActions: faster to instantiate and allows for disabling cacheBuffer
- delay compiling and instantiating bottom edge

Description of the change

Various startup time improvements (1000ms on krillin):
- do not use inline Components for dialogs and popovers.
- do not use inline Components for the empty page state
- do not use inline Component for ThreadsSectionDelegate
- do not use inline Component for SwipeItemDemo
- compile and instantiate threads scrollbar asynchronously
- conversations list: use new standard ListItem instead of custom ListItemWithActions: faster to instantiate and allows for disabling cacheBuffer
- delay compiling and instantiating bottom edge

Revision history for this message

system-apps-ci-bot (system-apps-ci-bot) wrote on 2016-10-04:

#

Click here to trigger a rebuild:
https://jenkins.canonical.com/system-apps/job/lp-messaging-app-ci/131/rebuild

FAILED: Continuous integration, rev:605
https://jenkins.canonical.com/system-apps/job/lp-messaging-app-ci/131/
Executed test runs:
    FAILURE: https://jenkins.canonical.com/system-apps/job/build/1733/console
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-0-fetch/1733
    FAILURE: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=vivid+overlay/1578/console
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=xenial+overlay/1578
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=xenial+overlay/1578/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=yakkety/1578
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=yakkety/1578/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=vivid+overlay/1578
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=vivid+overlay/1578/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=xenial+overlay/1578
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=xenial+overlay/1578/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=yakkety/1578
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=yakkety/1578/artifact/output/*zip*/output.zip
    FAILURE: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=vivid+overlay/1578/console
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=xenial+overlay/1578
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=xenial+overlay/1578/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=yakkety/1578
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=yakkety/1578/artifact/output/*zip*/output.zip

Click here to trigger a rebuild:
https://jenkins.canonical.com/system-apps/job/lp-messaging-app-ci/131/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

Tiago Salem Herrmann (tiagosh) wrote on 2016-10-05:

#

Found just one small issue.
Otherwise it looks good to me.

review: Approve

Revision history for this message

Tiago Salem Herrmann (tiagosh) wrote on 2016-10-05:

#

oops, actually marking as "needs fixing" until the issue is resolved.

review: Needs Fixing

Revision history for this message

Florian Boucault (fboucault) on 2016-10-06:

#

lp://staging/~fboucault/messaging-app/startup_time_return updated on 2016-10-06

606. By Florian Boucault on 2016-10-06: Added missing import in ParticipantsPopover

Revision history for this message

system-apps-ci-bot (system-apps-ci-bot) wrote on 2016-10-06:

#

Click here to trigger a rebuild:
https://jenkins.canonical.com/system-apps/job/lp-messaging-app-ci/132/rebuild

FAILED: Continuous integration, rev:606
https://jenkins.canonical.com/system-apps/job/lp-messaging-app-ci/132/
Executed test runs:
    FAILURE: https://jenkins.canonical.com/system-apps/job/build/1761/console
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-0-fetch/1761
    FAILURE: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=vivid+overlay/1606/console
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=xenial+overlay/1606
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=xenial+overlay/1606/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=yakkety/1606
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=yakkety/1606/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=vivid+overlay/1606
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=vivid+overlay/1606/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=xenial+overlay/1606
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=xenial+overlay/1606/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=yakkety/1606
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=yakkety/1606/artifact/output/*zip*/output.zip
    FAILURE: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=vivid+overlay/1606/console
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=xenial+overlay/1606
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=xenial+overlay/1606/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=yakkety/1606
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=yakkety/1606/artifact/output/*zip*/output.zip

Click here to trigger a rebuild:
https://jenkins.canonical.com/system-apps/job/lp-messaging-app-ci/132/rebuild

review: Needs Fixing (continuous-integration)

messaging-app

Merge lp://staging/~fboucault/messaging-app/startup_time_return into lp://staging/messaging-app

Commit message

Description of the change

Preview Diff

Subscribers