camera-app

Merge lp://staging/~fboucault/camera-app/location_metadata into lp://staging/camera-app

  1. location_metadata
  2. Merge into trunk
Proposed by Florian Boucault
Status: Merged
Approved by: Florian Boucault
Approved revision: 311
Merge reported by: Florian Boucault
Merged at revision: not available
Proposed branch: lp://staging/~fboucault/camera-app/location_metadata
Merge into: lp://staging/camera-app
Diff against target: 79 lines (+23/-3)
3 files modified
ViewFinderOverlay.qml (+19/-1)
camera-apparmor.json (+3/-2)
debian/control (+1/-0)
To merge this branch: bzr merge lp://staging/~fboucault/camera-app/location_metadata
Reviewer Review Type Date Requested Status
PS Jenkins bot continuous-integration Approve
Olivier Tilloy Approve
Review via email: mp+227037@code.staging.launchpad.net

Commit message

Enable GPS location saving into EXIF photo's metadata.

To post a comment you must log in.
lp://staging/~fboucault/camera-app/location_metadata updated
308. By Florian Boucault

Enable GPS location saving into EXIF photo's metadata.

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:308
http://jenkins.qa.ubuntu.com/job/camera-app-ci/234/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/camera-app-utopic-amd64-ci/50
    SUCCESS: http://jenkins.qa.ubuntu.com/job/camera-app-utopic-armhf-ci/50
        deb: http://jenkins.qa.ubuntu.com/job/camera-app-utopic-armhf-ci/50/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/camera-app-utopic-i386-ci/50
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-click-autopilot-utopic-touch/195
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-utopic/1750
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-click-autopilot-runner-mako/339
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-click-builder-utopic-armhf/283
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/9950
    SUCCESS: http://jenkins.qa.ubuntu.com/job/autopilot-testrunner-otto-utopic/1469
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-amd64/1960
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-amd64/1960/artifact/work/output/*zip*/output.zip

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/camera-app-ci/234/rebuild

review: Approve (continuous-integration)
lp://staging/~fboucault/camera-app/location_metadata updated
309. By Florian Boucault

Merged trunk

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:309
http://jenkins.qa.ubuntu.com/job/camera-app-ci/235/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/camera-app-utopic-amd64-ci/51
    SUCCESS: http://jenkins.qa.ubuntu.com/job/camera-app-utopic-armhf-ci/51
        deb: http://jenkins.qa.ubuntu.com/job/camera-app-utopic-armhf-ci/51/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/camera-app-utopic-i386-ci/51
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-click-autopilot-utopic-touch/196
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-utopic/1778
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-click-autopilot-runner-mako/340
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-click-builder-utopic-armhf/288
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/9995
    SUCCESS: http://jenkins.qa.ubuntu.com/job/autopilot-testrunner-otto-utopic/1491
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-amd64/1991
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-amd64/1991/artifact/work/output/*zip*/output.zip

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/camera-app-ci/235/rebuild

review: Approve (continuous-integration)
Revision history for this message
Olivier Tilloy (osomon) wrote :

30 + camera.imageCapture.setMetadata("GPSAltitude", positionSource.position.coordinate.altitude);

before setting the altitude attribute, you should probably check the value of positionSource.position.altitudeValid

Revision history for this message
Olivier Tilloy (osomon) wrote :

Before writing the metadata, you should probably do something like that:

    var position = positionSource.position

and then use this variable instead of always referring to positionSource.position (in case it is updated in the meantime, leading to two different positions being used for the metadata of one picture)

Revision history for this message
Olivier Tilloy (osomon) wrote :

The changes otherwise look good to me (not functionally tested though).

review: Approve
lp://staging/~fboucault/camera-app/location_metadata updated
310. By Florian Boucault

Check altitude's validity. Do not constantly call positionSource.position.

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:310
http://jenkins.qa.ubuntu.com/job/camera-app-ci/236/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/camera-app-utopic-amd64-ci/52
    SUCCESS: http://jenkins.qa.ubuntu.com/job/camera-app-utopic-armhf-ci/52
        deb: http://jenkins.qa.ubuntu.com/job/camera-app-utopic-armhf-ci/52/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/camera-app-utopic-i386-ci/52
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-click-autopilot-utopic-touch/197
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-utopic/1785/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-click-autopilot-runner-mako/341
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-click-builder-utopic-armhf/289
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/10003
    FAILURE: http://jenkins.qa.ubuntu.com/job/autopilot-testrunner-otto-utopic/1495/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-amd64/1998
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-amd64/1998/artifact/work/output/*zip*/output.zip

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/camera-app-ci/236/rebuild

review: Needs Fixing (continuous-integration)
lp://staging/~fboucault/camera-app/location_metadata updated
311. By Florian Boucault

Empty

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:311
http://jenkins.qa.ubuntu.com/job/camera-app-ci/237/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/camera-app-utopic-amd64-ci/53
    SUCCESS: http://jenkins.qa.ubuntu.com/job/camera-app-utopic-armhf-ci/53
        deb: http://jenkins.qa.ubuntu.com/job/camera-app-utopic-armhf-ci/53/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/camera-app-utopic-i386-ci/53
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-click-autopilot-utopic-touch/203
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-utopic/1818
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-click-autopilot-runner-mako/346
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-click-builder-utopic-armhf/297
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/10061
    SUCCESS: http://jenkins.qa.ubuntu.com/job/autopilot-testrunner-otto-utopic/1524
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-amd64/2036
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-amd64/2036/artifact/work/output/*zip*/output.zip

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/camera-app-ci/237/rebuild

review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches