camera-app

Merge lp://staging/~fboucault/camera-app/do_not_focus_outside_viewfinder into lp://staging/camera-app/staging

  1. do_not_focus_outside_viewfinder
  2. Merge into staging
Proposed by Florian Boucault
Status: Merged
Approved by: Ugo Riboni
Approved revision: 661
Merged at revision: 661
Proposed branch: lp://staging/~fboucault/camera-app/do_not_focus_outside_viewfinder
Merge into: lp://staging/camera-app/staging
Diff against target: 24 lines (+9/-5)
1 file modified
ViewFinderView.qml (+9/-5)
To merge this branch: bzr merge lp://staging/~fboucault/camera-app/do_not_focus_outside_viewfinder
Reviewer Review Type Date Requested Status
Ugo Riboni (community) Approve
PS Jenkins bot continuous-integration Needs Fixing
Review via email: mp+288112@code.staging.launchpad.net

Commit message

Only accept manual focus on points inside the viewfinder.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:661
http://jenkins.qa.ubuntu.com/job/camera-app-staging-ci/47/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/camera-app-staging-vivid-amd64-ci/47
        deb: http://jenkins.qa.ubuntu.com/job/camera-app-staging-vivid-amd64-ci/47/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/camera-app-staging-vivid-armhf-ci/47
        deb: http://jenkins.qa.ubuntu.com/job/camera-app-staging-vivid-armhf-ci/47/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/camera-app-staging-vivid-i386-ci/47
        deb: http://jenkins.qa.ubuntu.com/job/camera-app-staging-vivid-i386-ci/47/artifact/work/output/*zip*/output.zip
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-click-autopilot-vivid-touch/424
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-click-autopilot-runner-touch/1094
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-click-builder-vivid-armhf/1023
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/27978

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/camera-app-staging-ci/47/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
Ugo Riboni (uriboni) wrote :

Works and looks as expected. Did you add a manual test for this to the test plan ?

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches