Ubuntu UI Toolkit

Merge lp://staging/~faenil/ubuntu-ui-toolkit/listitemlayout_fixes_and_docs into lp://staging/ubuntu-ui-toolkit/staging

  1. listitemlayout_fixes_and_docs
  2. Merge into staging
Proposed by Andrea Bernabei
Status: Merged
Approved by: Zsombor Egri
Approved revision: 1798
Merged at revision: 1800
Proposed branch: lp://staging/~faenil/ubuntu-ui-toolkit/listitemlayout_fixes_and_docs
Merge into: lp://staging/ubuntu-ui-toolkit/staging
Diff against target: 289 lines (+140/-14)
4 files modified
src/Ubuntu/Components/plugin/privates/threelabelsslot_p.cpp (+10/-7)
src/Ubuntu/Components/plugin/privates/threelabelsslot_p.h (+3/-1)
src/Ubuntu/Components/plugin/uclistitemlayout.cpp (+80/-4)
tests/unit_x11/tst_components/tst_slotslayout.qml (+47/-2)
To merge this branch: bzr merge lp://staging/~faenil/ubuntu-ui-toolkit/listitemlayout_fixes_and_docs
Reviewer Review Type Date Requested Status
Zsombor Egri Approve
PS Jenkins bot continuous-integration Approve
Review via email: mp+281919@code.staging.launchpad.net

Commit message

Fix ListItemLayout multiline labels positioning and add docs about aliasing labels properties

Visual changes reviewed by Jouni Helminen

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:1798
http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-ci/2703/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-vivid-amd64-ci/1426
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-vivid-armhf-ci/1429
        deb: http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-vivid-armhf-ci/1429/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-vivid-i386-ci/1425

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-ci/2703/rebuild

review: Approve (continuous-integration)
Revision history for this message
Zsombor Egri (zsombi) wrote :

Why the default top margin for the title was changed? Some design requirement?

review: Needs Information
Revision history for this message
Zsombor Egri (zsombi) wrote :

Ok, code looks nice, docs as well, design change should have been written in the description so reviewer knows what additional change is added beside the fix. Next time please do a separate MR for that. It doesn't belong to this fix logically.

review: Approve
Revision history for this message
Andrea Bernabei (faenil) wrote :

The change in title margin is a consequence of changing the labels anchors.

The change in title margin was suggested and reviewed by Jouni Helminen (Visual Designer) on 8th Jan

Revision history for this message
Andrea Bernabei (faenil) wrote :

> Why the default top margin for the title was changed? Some design requirement?

it is a consequence of the anchor changes. Without that, the visual would look different. So we're actually trying to keep the same visual as before here, not changing it ;)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches