Ubuntu UI Toolkit

Merge lp://staging/~faenil/ubuntu-ui-toolkit/listItem_slotsLayout into lp://staging/ubuntu-ui-toolkit/staging

listItem_slotsLayout
Merge into staging

Proposed by Andrea Bernabei on 2015-09-09

Status:

Merged

Approved by:

Zsombor Egri on 2015-10-01

Approved revision:

1308

Merged at revision:

1665

Proposed branch:

lp://staging/~faenil/ubuntu-ui-toolkit/listItem_slotsLayout

Merge into:

lp://staging/ubuntu-ui-toolkit/staging

Diff against target:

4291 lines (+3949/-41)

30 files modified

components.api (+23/-0)
examples/ubuntu-ui-toolkit-gallery/ListItemLayouts.qml (+267/-0)
examples/ubuntu-ui-toolkit-gallery/ListItemWithLabel.qml (+5/-9)
examples/ubuntu-ui-toolkit-gallery/NewListItems.qml (+19/-19)
examples/ubuntu-ui-toolkit-gallery/WidgetsModel.qml (+10/-5)
src/Ubuntu/Components/1.3/ProgressionSlot.qml (+59/-0)
src/Ubuntu/Components/ComponentModule.pro (+2/-3)
src/Ubuntu/Components/plugin/plugin.cpp (+6/-0)
src/Ubuntu/Components/plugin/plugin.pri (+9/-2)
src/Ubuntu/Components/plugin/privates/threelabelsslot_p.cpp (+223/-0)
src/Ubuntu/Components/plugin/privates/threelabelsslot_p.h (+76/-0)
src/Ubuntu/Components/plugin/uclistitemlayout.cpp (+275/-0)
src/Ubuntu/Components/plugin/uclistitemlayout.h (+42/-0)
src/Ubuntu/Components/plugin/ucslotslayout.cpp (+1296/-0)
src/Ubuntu/Components/plugin/ucslotslayout.h (+154/-0)
src/Ubuntu/Components/plugin/ucslotslayout_p.h (+149/-0)
src/Ubuntu/Components/qmldir (+1/-0)
tests/unit/tst_performance/ListItemWithInlineActionsAndFourContainersList.qml (+66/-0)
tests/unit/tst_performance/ListItemWithInlineActionsAndFourMouseAreas.qml (+66/-0)
tests/unit/tst_performance/ListOfCustomListItemLayouts.qml (+94/-0)
tests/unit/tst_performance/ListOfEmptyListItemLayout.qml (+32/-0)
tests/unit/tst_performance/ListOfEmptyListItemLayout_withProgression.qml (+32/-0)
tests/unit/tst_performance/ListOfHardcodedFourContainersLayout.qml (+32/-0)
tests/unit/tst_performance/ListOfHardcodedFourContainersLayout_withItems.qml (+34/-0)
tests/unit/tst_performance/ListOfListItemLayout_complex1.qml (+36/-0)
tests/unit/tst_performance/ListOfListItemLayout_complex2.qml (+50/-0)
tests/unit/tst_performance/ListOfListItemLayout_labelsOnly.qml (+33/-0)
tests/unit/tst_performance/tst_performance.cpp (+10/-2)
tests/unit/tst_performance/tst_performance.pro (+9/-1)
tests/unit_x11/tst_components/tst_slotslayout.qml (+839/-0)

To merge this branch:

bzr merge lp://staging/~faenil/ubuntu-ui-toolkit/listItem_slotsLayout

High

Fix Released

Link a bug report

Reviewer	Review Type	Date Requested	Status
PS Jenkins bot	continuous-integration		Approve on 2015-10-01
Zsombor Egri		2015-09-09	Approve on 2015-10-01
Review via email: mp+270581@code.staging.launchpad.net

Description of the change

This MR adds the SlotsLayout and ListItemLayout C++ components, with documentation and tests

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2015-09-09:

FAILED: Continuous integration, rev:1248
http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-ci/2212/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-vivid-amd64-ci/940/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-vivid-armhf-ci/942/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-vivid-i386-ci/939/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-ci/2212/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

Zsombor Egri (zsombi) wrote on 2015-09-10:

Here you go, comments in between the lines

review: Needs Fixing

Revision history for this message

Andrea Bernabei (faenil) wrote on 2015-09-10:

I addressed most of the comment, thanks for the review :)

I have a few concerns, but we can discuss on Monday ;)

lp://staging/~faenil/ubuntu-ui-toolkit/listItem_slotsLayout updated on 2015-09-16

1249. By Andrea Bernabei on 2015-09-10: SlotsLayout: add enum to represent slots positioning modes
1250. By Andrea Bernabei on 2015-09-10: SlotsLayout: read labels' font colour from the theme context property
1251. By Andrea Bernabei on 2015-09-10: SlotsLayout: connect to chevron attached properties the same way we do for other slots
1252. By Andrea Bernabei on 2015-09-10: SlotsLayout: use qmlInfo() instead of qDebug() or qWarning() so that the output is shown in release mode as well
1253. By Andrea Bernabei on 2015-09-10: SlotsLayout: style fixes and a bit of refactoring
1254. By Andrea Bernabei on 2015-09-10: SlotsLayout: use bitfields for bools
1255. By Andrea Bernabei on 2015-09-10: SlotsLayout: make the layout a focus scope
1256. By Andrea Bernabei on 2015-09-13: SlotsLayout: always show chevron as last slot and take it into account in max slots available var
1257. By Andrea Bernabei on 2015-09-13: SlotsLayout: make leadingSlots/trailingSlots members of the private impl
1258. By Andrea Bernabei on 2015-09-13: SlotsLayout: refactoring of layout process
1259. By Andrea Bernabei on 2015-09-13: SlotsLayout: ignore invisible slots
1260. By Andrea Bernabei on 2015-09-13: SlotsLayout: delete bool ready, use componentComplete instead
1261. By Andrea Bernabei on 2015-09-14: SlotsLayout: expose content margins as grouped property (new class UCSlotsLayoutMargins)
1262. By Andrea Bernabei on 2015-09-14: SlotsLayout: remove old QML experimental list item layout files
1263. By Andrea Bernabei on 2015-09-14: merge stagin
1264. By Andrea Bernabei on 2015-09-14: SlotsLayout: add private implementation for slots attached property
1265. By Andrea Bernabei on 2015-09-15: SlotsLayout: replace relayoutNeeded signal with direct calls to relayout()
1266. By Andrea Bernabei on 2015-09-16: SlotsLayout: add API to position a slot at beginning/end of leading/trailing slots
1267. By Andrea Bernabei on 2015-09-16: SlotsLayout: replace internal QQuickPaintedItem chevron with QML ProgressionSlot to allow more flexibility
1268. By Andrea Bernabei on 2015-09-16: merge staging
1269. By Andrea Bernabei on 2015-09-16: SlotsLayout: add copyright headers

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2015-09-16:

FAILED: Continuous integration, rev:1269
http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-ci/2236/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-vivid-amd64-ci/964/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-vivid-armhf-ci/966/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-vivid-i386-ci/963/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-ci/2236/rebuild

review: Needs Fixing (continuous-integration)

lp://staging/~faenil/ubuntu-ui-toolkit/listItem_slotsLayout updated on 2015-09-16

1270. By Andrea Bernabei on 2015-09-16: SlotsLayout: commit current components.api file change

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2015-09-16:

FAILED: Continuous integration, rev:1270
http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-ci/2239/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-vivid-amd64-ci/967
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-vivid-armhf-ci/969
        deb: http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-vivid-armhf-ci/969/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-vivid-i386-ci/966

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-ci/2239/rebuild

review: Needs Fixing (continuous-integration)

lp://staging/~faenil/ubuntu-ui-toolkit/listItem_slotsLayout updated on 2015-09-21

1271. By Andrea Bernabei on 2015-09-17: SlotsLayout: add an example with RTL layout
1272. By Andrea Bernabei on 2015-09-18: SlotsLayout: replace internal labels with a customizable mainSlot
1273. By Andrea Bernabei on 2015-09-18: SlotsLayout: add C++ ThreeLabelsSlot (temp name) to overcome slowness of using 3 Labels as mainSlot
1274. By Andrea Bernabei on 2015-09-18: SlotsLayout: use lazy initialization for labels (instead of allocating them on the stack)
1275. By Andrea Bernabei on 2015-09-18: SlotsLayout: cache UCTheme and palette color as they're expensive to query
1276. By Andrea Bernabei on 2015-09-19: SlotsLayout: rename properties according to API review agreements
1277. By Andrea Bernabei on 2015-09-21: SlotsLayout: first batch of tests + bug fix

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2015-09-21:

FAILED: Continuous integration, rev:1277
http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-ci/2253/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-vivid-amd64-ci/981/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-vivid-armhf-ci/983/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-vivid-i386-ci/980/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-ci/2253/rebuild

review: Needs Fixing (continuous-integration)

lp://staging/~faenil/ubuntu-ui-toolkit/listItem_slotsLayout updated on 2015-09-22

1278. By Andrea Bernabei on 2015-09-22: SlotsLayout: add first documentation, missing code examples

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2015-09-22:

FAILED: Continuous integration, rev:1278
http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-ci/2270/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-vivid-amd64-ci/998/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-vivid-armhf-ci/1000/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-vivid-i386-ci/997/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-ci/2270/rebuild

review: Needs Fixing (continuous-integration)

lp://staging/~faenil/ubuntu-ui-toolkit/listItem_slotsLayout updated on 2015-09-22

1279. By Andrea Bernabei on 2015-09-22: SlotsLayout: replace leading/trailingPadding of the slot with UCSlotsLayoutPadding, i.e. add top and bottom padding to slots attached properties

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2015-09-22:

FAILED: Continuous integration, rev:1279
http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-ci/2273/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-vivid-amd64-ci/1001/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-vivid-armhf-ci/1003/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-vivid-i386-ci/1000/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-ci/2273/rebuild

review: Needs Fixing (continuous-integration)

lp://staging/~faenil/ubuntu-ui-toolkit/listItem_slotsLayout updated on 2015-09-22

1280. By Andrea Bernabei on 2015-09-22: SlotsLayout: add relative positioning feature, you can now use SlotsLayout.Leading+1 as position, to decide a sorting order between slots
1281. By Andrea Bernabei on 2015-09-22: SlotsLayout: fix ProgressionSlot position

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2015-09-23:

FAILED: Continuous integration, rev:1280
http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-ci/2276/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-vivid-amd64-ci/1004/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-vivid-armhf-ci/1006/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-vivid-i386-ci/1003/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-ci/2276/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2015-09-23:

FAILED: Continuous integration, rev:1281
http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-ci/2277/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-vivid-amd64-ci/1005/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-vivid-armhf-ci/1007/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-vivid-i386-ci/1004/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-ci/2277/rebuild

review: Needs Fixing (continuous-integration)

lp://staging/~faenil/ubuntu-ui-toolkit/listItem_slotsLayout updated on 2015-09-23

1282. By Andrea Bernabei on 2015-09-23: merge staging
1283. By Andrea Bernabei on 2015-09-23: SlotsLayout: update .api file

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2015-09-23:

PASSED: Continuous integration, rev:1283
http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-ci/2280/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-vivid-amd64-ci/1008
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-vivid-armhf-ci/1010
        deb: http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-vivid-armhf-ci/1010/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-vivid-i386-ci/1007

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-ci/2280/rebuild

review: Approve (continuous-integration)

lp://staging/~faenil/ubuntu-ui-toolkit/listItem_slotsLayout updated on 2015-09-23

1284. By Andrea Bernabei on 2015-09-23: SlotsLayout: add more tests
1285. By Andrea Bernabei on 2015-09-23: SlotsLayout: ensure invisible items are ignore while computing implicitHeight
1286. By Andrea Bernabei on 2015-09-23: SlotsLayout: add more tests and fix bugs that those tests uncovered

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2015-09-23:

FAILED: Continuous integration, rev:1286
http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-ci/2288/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-vivid-amd64-ci/1016/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-vivid-armhf-ci/1018/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-vivid-i386-ci/1015/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-ci/2288/rebuild

review: Needs Fixing (continuous-integration)

lp://staging/~faenil/ubuntu-ui-toolkit/listItem_slotsLayout updated on 2015-09-23

1287. By Andrea Bernabei on 2015-09-23: SlotsLayout: many tests, many bugfixes
1288. By Andrea Bernabei on 2015-09-23: merge staging

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2015-09-23:

PASSED: Continuous integration, rev:1288
http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-ci/2290/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-vivid-amd64-ci/1018
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-vivid-armhf-ci/1020
        deb: http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-vivid-armhf-ci/1020/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-vivid-i386-ci/1017

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-ci/2290/rebuild

review: Approve (continuous-integration)

lp://staging/~faenil/ubuntu-ui-toolkit/listItem_slotsLayout updated on 2015-09-24

1289. By Andrea Bernabei on 2015-09-24: SlotsLayout: add ProgressionSlot doc and code examples in SlotsLayout and ListItemLayout docs

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2015-09-24:

PASSED: Continuous integration, rev:1289
http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-ci/2291/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-vivid-amd64-ci/1019
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-vivid-armhf-ci/1021
        deb: http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-vivid-armhf-ci/1021/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-vivid-i386-ci/1018

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-ci/2291/rebuild

review: Approve (continuous-integration)

lp://staging/~faenil/ubuntu-ui-toolkit/listItem_slotsLayout updated on 2015-09-24

1290. By Andrea Bernabei on 2015-09-24: SlotsLayout: no need to update slots bbox height when layout's padding changes
1291. By Andrea Bernabei on 2015-09-24: SlotsLayout: more documentation, more bugfixes
1292. By Andrea Bernabei on 2015-09-24: SlotsLayout: use different integers for enum values to decrease chances of int overflow

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2015-09-24:

FAILED: Continuous integration, rev:1292
http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-ci/2301/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-vivid-amd64-ci/1029/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-vivid-armhf-ci/1031/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-vivid-i386-ci/1028/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-ci/2301/rebuild

review: Needs Fixing (continuous-integration)

lp://staging/~faenil/ubuntu-ui-toolkit/listItem_slotsLayout updated on 2015-09-25

1293. By Andrea Bernabei on 2015-09-25: SlotsLayout: more documentation

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2015-09-25:

FAILED: Continuous integration, rev:1293
http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-ci/2311/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-vivid-amd64-ci/1039/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-vivid-armhf-ci/1041/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-vivid-i386-ci/1038/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-ci/2311/rebuild

review: Needs Fixing (continuous-integration)

lp://staging/~faenil/ubuntu-ui-toolkit/listItem_slotsLayout updated on 2015-09-25

1294. By Andrea Bernabei on 2015-09-25: merge staging
1295. By Andrea Bernabei on 2015-09-25: SlotsLayout: improve documentation, WIP update UI gallery

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2015-09-25:

FAILED: Continuous integration, rev:1295
http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-ci/2314/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-vivid-amd64-ci/1042/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-vivid-armhf-ci/1044/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-vivid-i386-ci/1041/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-ci/2314/rebuild

review: Needs Fixing (continuous-integration)

lp://staging/~faenil/ubuntu-ui-toolkit/listItem_slotsLayout updated on 2015-09-28

1296. By Andrea Bernabei on 2015-09-28: SlotsLayout: more updates to UI gallery plus use UCLabel instead of QQuickText for ListItemLayout labels
1297. By Andrea Bernabei on 2015-09-28: merge stagin

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2015-09-28:

FAILED: Continuous integration, rev:1297
http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-ci/2318/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-vivid-amd64-ci/1046/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-vivid-armhf-ci/1048/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-vivid-i386-ci/1045/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-ci/2318/rebuild

review: Needs Fixing (continuous-integration)

lp://staging/~faenil/ubuntu-ui-toolkit/listItem_slotsLayout updated on 2015-09-28

1298. By Andrea Bernabei on 2015-09-28: SlotsLayout: add ListItemLayout licence header

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2015-09-28:

FAILED: Continuous integration, rev:1298
http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-ci/2320/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-vivid-amd64-ci/1048/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-vivid-armhf-ci/1050/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-vivid-i386-ci/1047/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-ci/2320/rebuild

review: Needs Fixing (continuous-integration)

lp://staging/~faenil/ubuntu-ui-toolkit/listItem_slotsLayout updated on 2015-09-28

1299. By Andrea Bernabei on 2015-09-28: Merge staging and move ThreeLabelsSlot to separate files
1300. By Andrea Bernabei on 2015-09-28: SlotsLayout: improve docs
1301. By Andrea Bernabei on 2015-09-28: SlotsLayout: doc fix

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2015-09-28:

FAILED: Continuous integration, rev:1301
http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-ci/2324/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-vivid-amd64-ci/1052/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-vivid-armhf-ci/1054/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-vivid-i386-ci/1051/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-ci/2324/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

Zsombor Egri (zsombi) wrote on 2015-09-29:

Lots of things to do still :)
No qDebug() is allowed in the code. Use qWarning() or qFatal() if needed.
If you need theming, see UCThemingExtension, you can benefit of that!

See Label stuff!

And push the changes at once, so I can review them in a separate and compact revision. Thanks!! Good stuff otherwise!

review: Needs Fixing

lp://staging/~faenil/ubuntu-ui-toolkit/listItem_slotsLayout updated on 2015-09-29

1302. By Andrea Bernabei on 2015-09-29: merge staging
1303. By Andrea Bernabei on 2015-09-29: SlotsLayout: code and visual review changes

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2015-09-29:

PASSED: Continuous integration, rev:1303
http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-ci/2330/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-vivid-amd64-ci/1058
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-vivid-armhf-ci/1060
        deb: http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-vivid-armhf-ci/1060/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-vivid-i386-ci/1057

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-ci/2330/rebuild

review: Approve (continuous-integration)

lp://staging/~faenil/ubuntu-ui-toolkit/listItem_slotsLayout updated on 2015-09-30

1304. By Andrea Bernabei on 2015-09-30: ListItemLayout: add labels positioning tests, override setMainSlot to disable replacing mainSlot, deallocate old C++ mainSlots
1305. By Andrea Bernabei on 2015-09-30: merge staging
1306. By Andrea Bernabei on 2015-09-30: ListItemLayout: improve labels layout tests, fix one corner case

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2015-09-30:

PASSED: Continuous integration, rev:1305
http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-ci/2341/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-vivid-amd64-ci/1069
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-vivid-armhf-ci/1071
        deb: http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-vivid-armhf-ci/1071/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-vivid-i386-ci/1068

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-ci/2341/rebuild

review: Approve (continuous-integration)

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2015-09-30:

PASSED: Continuous integration, rev:1306
http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-ci/2343/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-vivid-amd64-ci/1071
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-vivid-armhf-ci/1073
        deb: http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-vivid-armhf-ci/1073/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-vivid-i386-ci/1070

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-ci/2343/rebuild

review: Approve (continuous-integration)

Revision history for this message

Zsombor Egri (zsombi) wrote on 2015-09-30:

One small change and we're good to go!!! We're almost there!

review: Needs Fixing

lp://staging/~faenil/ubuntu-ui-toolkit/listItem_slotsLayout updated on 2015-10-01

1307. By Andrea Bernabei on 2015-09-30: ListItemLayout: add more labels layout tests
1308. By Andrea Bernabei on 2015-10-01: ListItemLayout: move UCThreeLabelsSlot files to privates folder, add test for customization of mainSlot