goget-ubuntu-touch

Merge lp://staging/~faenil/goget-ubuntu-touch/emulator_default_to_stable into lp://staging/goget-ubuntu-touch

  1. emulator_default_to_stable
  2. Merge into trunk
Proposed by Andrea Bernabei
Status: Merged
Approved by: Łukasz Zemczak
Approved revision: 229
Merged at revision: 232
Proposed branch: lp://staging/~faenil/goget-ubuntu-touch/emulator_default_to_stable
Merge into: lp://staging/goget-ubuntu-touch
Diff against target: 12 lines (+1/-1)
1 file modified
ubuntu-emulator/create.go (+1/-1)
To merge this branch: bzr merge lp://staging/~faenil/goget-ubuntu-touch/emulator_default_to_stable
Reviewer Review Type Date Requested Status
Simon Fels Approve
Łukasz Zemczak Approve
Review via email: mp+297893@code.staging.launchpad.net

Commit message

Default to ubuntu-touch/stable instead of ubuntu-touch/devel for emulator creation

Description of the change

Default to ubuntu-touch/stable instead of ubuntu-touch/devel for emulator creation

NOTE: this is untested, it looked like a very simple fix so I had a look at the sourcecode and pushed this MIR. Someone who has more knowledge of the tool should review this change, although I believe it's quite innocent

To post a comment you must log in.
Revision history for this message
Łukasz Zemczak (sil2100) wrote :

Yeah, so I don't know much of the codebase myself but this change looks safe and logical. +1 from my side.

review: Approve
Revision history for this message
Simon Fels (morphis) wrote :

Why is this untested? Building this is very easy. Just do

$ debian/rules clean build

and you get the binaries (but you need all build-deps installed first).

-1 until someone tested this.

review: Needs Fixing
Revision history for this message
Andrea Bernabei (faenil) wrote :

Here's the test you requested Simon :)

Before:
~/emulator_default_to_stable$ sudo ubuntu-emulator create lol2
[sudo] password for faenil:
Creating "lol2" from ubuntu-touch/devel revision 2
Downloading...

After:
~/emulator_default_to_stable$ sudo ./obj-x86_64-linux-gnu/bin/ubuntu-emulator create test
Creating "test" from ubuntu-touch/stable revision 19
Downloading...
Setting up...
Setting up a default password for phablet to: '0000'
Creating snapshots for disks...
Succesfully created emulator instance test in <path_omitted>

The emulator booted to the new OOBE as well.

Revision history for this message
Simon Fels (morphis) wrote :

LGTM

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches