Merge lp://staging/~facundo/ubuntuone-client/stable-ping-it-baby into lp://staging/ubuntuone-client/stable-1-4
Proposed by
Facundo Batista
| Status: | Merged | ||||
|---|---|---|---|---|---|
| Approved by: | Facundo Batista | ||||
| Approved revision: | 720 | ||||
| Merged at revision: | 725 | ||||
| Proposed branch: | lp://staging/~facundo/ubuntuone-client/stable-ping-it-baby | ||||
| Merge into: | lp://staging/ubuntuone-client/stable-1-4 | ||||
| Diff against target: |
233 lines (+123/-12) 3 files modified
contrib/testing/testcase.py (+5/-0) tests/syncdaemon/test_action_queue.py (+93/-1) ubuntuone/syncdaemon/action_queue.py (+25/-11) |
||||
| To merge this branch: | bzr merge lp://staging/~facundo/ubuntuone-client/stable-ping-it-baby | ||||
| Related bugs: |
|
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Lucio Torre (community) | Approve | ||
| Guillermo Gonzalez | Approve | ||
|
Review via email:
|
|||
Commit message
Client periodically pings the server to check connection.
Description of the change
Client periodically pings the server to check connection.
Tests included. Also added a small helper in the MementoHandler that is
useful for debugging while coding.
Note that I also had to fix an ugly monkeypatching that didn't let me log in debug.
Also note that I hardcoded the ping period. Maybe in the future we would want for it to be configurable, but I wanted to reduce the footprint to ease the SRU. I chose 10 minutes as a balance between time between pings and server load (having 500k connected clients to 16 servers, one ping each 10 mins will be 52 pings per second per server).
To post a comment you must log in.
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
looks good.