Merge lp://staging/~facundo/ubuntu-rest-scopes/urlopen-metrics into lp://staging/ubuntu-rest-scopes
Proposed by
Facundo Batista
| Status: | Merged |
|---|---|
| Approved by: | Roberto Alsina |
| Approved revision: | 410 |
| Merged at revision: | 411 |
| Proposed branch: | lp://staging/~facundo/ubuntu-rest-scopes/urlopen-metrics |
| Merge into: | lp://staging/ubuntu-rest-scopes |
| Diff against target: |
1425 lines (+316/-211) 20 files modified
src/rest_scopes.py (+38/-3) src/scopes/__init__.py (+4/-9) src/scopes/ebay.py (+2/-2) src/scopes/grooveshark.py (+2/-3) src/scopes/onlinemusic.py (+5/-2) src/scopes/openlibrary.py (+2/-2) src/scopes/reddit.py (+2/-2) src/scopes/remotevideos.py (+5/-2) src/scopes/sevendigital.py (+6/-7) src/scopes/tests/test_base.py (+9/-41) src/scopes/tests/test_openlibrary.py (+6/-7) src/scopes/tests/test_reddit.py (+4/-6) src/scopes/tests/test_sevendigital.py (+48/-52) src/scopes/tests/test_weatherchannel.py (+17/-18) src/scopes/tests/test_wikipedia.py (+20/-24) src/scopes/tests/test_yahoofinance.py (+9/-10) src/scopes/weatherchannel.py (+3/-3) src/scopes/wikipedia.py (+14/-9) src/scopes/yahoofinance.py (+6/-5) src/tests/test_rest_scopes.py (+114/-4) |
| To merge this branch: | bzr merge lp://staging/~facundo/ubuntu-rest-scopes/urlopen-metrics |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Roberto Alsina (community) | Approve | ||
|
Review via email:
|
|||
Commit message
Added metrics to centralized urlopen.
Description of the change
Added metrics to centralized urlopen.
Also I moved it to rest_scopes, out the app, so it can be accessed by other external entities (and made public other function, same reasoning).
Also, now it's not just urlopen, it also read().
Tests included, adjusted, etc.
To post a comment you must log in.
Revision history for this message
| Roberto Alsina (ralsina) | # |
review:
Approve
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
