Merge lp://staging/~facundo/ubuntu-rest-scopes/twc-surfacing-only-with-latlong into lp://staging/ubuntu-rest-scopes

Proposed by Facundo Batista
Status: Merged
Approved by: Roberto Alsina
Approved revision: 386
Merged at revision: 386
Proposed branch: lp://staging/~facundo/ubuntu-rest-scopes/twc-surfacing-only-with-latlong
Merge into: lp://staging/ubuntu-rest-scopes
Diff against target: 161 lines (+48/-10)
4 files modified
src/scopes/__init__.py (+14/-1)
src/scopes/tests/test_base.py (+14/-1)
src/scopes/tests/test_weatherchannel.py (+14/-5)
src/scopes/weatherchannel.py (+6/-3)
To merge this branch: bzr merge lp://staging/~facundo/ubuntu-rest-scopes/twc-surfacing-only-with-latlong
Reviewer Review Type Date Requested Status
Roberto Alsina (community) Approve
Review via email: mp+248952@code.staging.launchpad.net

Commit message

Assure lat/long is received in TWC surfacing, otherwise bailout with 400.

Description of the change

Assure lat/long is received in TWC surfacing, otherwise bailout with 400.

To be able to return an error code from the already-serving-scope, I added an exception and small functionality in the SimpleApp for all scopes to be able to do that.

Tests included for everything.

To post a comment you must log in.
Revision history for this message
Roberto Alsina (ralsina) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches