Merge lp://staging/~facundo/ubuntu-rest-scopes/twc-support-bad-response into lp://staging/ubuntu-rest-scopes
Proposed by
Facundo Batista
| Status: | Superseded |
|---|---|
| Proposed branch: | lp://staging/~facundo/ubuntu-rest-scopes/twc-support-bad-response |
| Merge into: | lp://staging/ubuntu-rest-scopes |
| Diff against target: |
327 lines (+72/-74) 6 files modified
src/scopes/__init__.py (+19/-1) src/scopes/sevendigital.py (+5/-2) src/scopes/tests/test_base.py (+20/-0) src/scopes/tests/test_sevendigital.py (+8/-1) src/scopes/tests/test_weatherchannel.py (+6/-33) src/scopes/weatherchannel.py (+14/-37) |
| To merge this branch: | bzr merge lp://staging/~facundo/ubuntu-rest-scopes/twc-support-bad-response |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Roberto Alsina (community) | Approve | ||
|
Review via email:
|
|||
This proposal has been superseded by a proposal from 2015-04-13.
Commit message
Made TWC to use new structure to support backend errors.
Description of the change
Made TWC to use new structure to support backend errors.
This deprecated ForecastNotFound and LocationNotFound errors, but as to give proper information I enhanced BackendDataError to support a full message (not only an exception).
Finally, I removed theget_
To post a comment you must log in.
Revision history for this message
| Roberto Alsina (ralsina) | # |
review:
Approve
Unmerged revisions
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
