Merge lp://staging/~facundo/ubuntu-rest-scopes/twc-no-results into lp://staging/ubuntu-rest-scopes

Proposed by Facundo Batista
Status: Merged
Approved by: Roberto Alsina
Approved revision: 343
Merged at revision: 343
Proposed branch: lp://staging/~facundo/ubuntu-rest-scopes/twc-no-results
Merge into: lp://staging/ubuntu-rest-scopes
Diff against target: 1428 lines (+1402/-0)
3 files modified
src/scopes/tests/fixtures/weatherchannel-no-narrative.json (+1386/-0)
src/scopes/tests/test_weatherchannel.py (+14/-0)
src/scopes/weatherchannel.py (+2/-0)
To merge this branch: bzr merge lp://staging/~facundo/ubuntu-rest-scopes/twc-no-results
Reviewer Review Type Date Requested Status
Roberto Alsina (community) Approve
Review via email: mp+242192@code.staging.launchpad.net

Commit message

Sometimes there are no results for the TWC landpage search.

Description of the change

Sometimes there are no results for the TWC landpage search.

Test included.

To post a comment you must log in.
Revision history for this message
Roberto Alsina (ralsina) wrote :

Why do we need a 1386 line json file to test "there is no result"? Just curious :-)

Revision history for this message
Roberto Alsina (ralsina) wrote :

Answered on IRC. +1

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches