Merge lp://staging/~facundo/ubuntu-rest-scopes/multi-column into lp://staging/ubuntu-rest-scopes

Proposed by Facundo Batista
Status: Merged
Approved by: Facundo Batista
Approved revision: 527
Merged at revision: 527
Proposed branch: lp://staging/~facundo/ubuntu-rest-scopes/multi-column
Merge into: lp://staging/ubuntu-rest-scopes
Diff against target: 1135 lines (+312/-115)
19 files modified
README.txt (+23/-0)
src/rest_scopes.py (+1/-1)
src/scopes/amazon.py (+22/-3)
src/scopes/ebay.py (+21/-0)
src/scopes/openlibrary.py (+14/-0)
src/scopes/reddit.py (+33/-11)
src/scopes/sevendigital.py (+28/-6)
src/scopes/tests/test_amazon.py (+11/-8)
src/scopes/tests/test_ebay.py (+12/-9)
src/scopes/tests/test_openlibrary.py (+10/-6)
src/scopes/tests/test_reddit.py (+18/-10)
src/scopes/tests/test_sevendigital.py (+11/-7)
src/scopes/tests/test_weatherchannel.py (+10/-7)
src/scopes/tests/test_wikipedia.py (+21/-19)
src/scopes/tests/test_yahoofinance.py (+12/-8)
src/scopes/weatherchannel.py (+14/-1)
src/scopes/wikipedia.py (+31/-17)
src/scopes/yahoofinance.py (+18/-0)
src/tests/test_translator.py (+2/-2)
To merge this branch: bzr merge lp://staging/~facundo/ubuntu-rest-scopes/multi-column
Reviewer Review Type Date Requested Status
Facundo Batista (community) Approve
Review via email: mp+296672@code.staging.launchpad.net

Commit message

Implement multi-column layouts for the various remote scopes.

Description of the change

Implement multi-column layouts for the various remote scopes.

I'm superseeding https://code.launchpad.net/~jamesh/ubuntu-rest-scopes/multi-column/+merge/288898 to be able to land it.

To post a comment you must log in.
Revision history for this message
Facundo Batista (facundo) wrote :

Approving it directly, as all review was done in the other MP ↑

review: Approve
Revision history for this message
Ubuntu One Auto Pilot (otto-pilot) wrote :

The attempt to merge lp:~facundo/ubuntu-rest-scopes/multi-column into lp:ubuntu-rest-scopes failed. Below is the output from the failed tests.

src/scopes/reddit.py:324:17: E225 missing whitespace around operator

.............................................................................................................................................................................................................................................................................................................................................................................
----------------------------------------------------------------------
Ran 365 tests in 15.877s

OK

527. By Facundo Batista

Fixed the lint issue.

Revision history for this message
Facundo Batista (facundo) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches