Ubuntu Rest Scopes

Merge lp://staging/~facundo/ubuntu-rest-scopes/amazon-hide-403 into lp://staging/ubuntu-rest-scopes

  1. amazon-hide-403
  2. Merge into trunk
Proposed by Facundo Batista
Status: Merged
Approved by: Facundo Batista
Approved revision: 525
Merged at revision: 525
Proposed branch: lp://staging/~facundo/ubuntu-rest-scopes/amazon-hide-403
Merge into: lp://staging/ubuntu-rest-scopes
Diff against target: 58 lines (+19/-2)
3 files modified
src/scopes/__init__.py (+4/-2)
src/scopes/amazon.py (+4/-0)
src/scopes/tests/test_base.py (+11/-0)
To merge this branch: bzr merge lp://staging/~facundo/ubuntu-rest-scopes/amazon-hide-403
Reviewer Review Type Date Requested Status
Guillermo Gonzalez Approve
Review via email: mp+296546@code.staging.launchpad.net

Commit message

Ignore 403s from Amazon.

Description of the change

Ignore 403s from Amazon.

These are spurious unresolved errors, after lot of tracking and not being able to see why had just a few of these per day, we decided to ignore them.

We can still see these errors in the logs and metrics (we just don't oops anymore, don't crash on the client, but return a 502), see:

    https://graphite.ubunet.canonical.com/render/?width=1200&height=800&&target=sum%28statsd.production.search.product.backend.ecs_amazonaws_*.403.*.rate%29&target=sum%28statsd.production.search.product.backend.ecs_amazonaws_*.200.*.rate%29

To post a comment you must log in.
Revision history for this message
Guillermo Gonzalez (verterok) wrote :

LGTM

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches