Merge lp://staging/~facundo/magicicada-server/remove-s3-network-error-handling into lp://staging/magicicada-server
Proposed by
Facundo Batista
| Status: | Merged |
|---|---|
| Approved by: | Natalia Bidart |
| Approved revision: | 5 |
| Merged at revision: | 7 |
| Proposed branch: | lp://staging/~facundo/magicicada-server/remove-s3-network-error-handling |
| Merge into: | lp://staging/magicicada-server |
| Diff against target: |
984 lines (+39/-703) 5 files modified
configs/development.yaml (+0/-2) src/server/content.py (+32/-142) src/server/errors.py (+0/-4) src/server/tests/test_content.py (+5/-553) src/server/upload.py (+2/-2) |
| To merge this branch: | bzr merge lp://staging/~facundo/magicicada-server/remove-s3-network-error-handling |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Natalia Bidart | Approve | ||
|
Review via email:
|
|||
Commit message
Removal of a lot of s3 web errors handling.
Description of the change
Removal of a lot of s3 web errors handling.
This is a first branch to remove a lot of code that will be removed later anyway when s3 disappears, but the idea is to reduce future changes.
To post a comment you must log in.
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
Looks good!
Curious why you replaced xrange with range.