Merge lp://staging/~facundo/magicicada-client/new-trash into lp://staging/magicicada-client
| Status: | Merged |
|---|---|
| Approved by: | Natalia Bidart |
| Approved revision: | 1442 |
| Merged at revision: | 1441 |
| Proposed branch: | lp://staging/~facundo/magicicada-client/new-trash |
| Merge into: | lp://staging/magicicada-client |
| Diff against target: |
293 lines (+55/-114) 7 files modified
Makefile (+6/-3) dependencies-devel.txt (+0/-1) requirements-devel.txt (+1/-0) requirements.txt (+1/-0) run-tests (+1/-9) ubuntuone/platform/os_helper/linux.py (+17/-29) ubuntuone/platform/tests/os_helper/test_linux.py (+29/-72) |
| To merge this branch: | bzr merge lp://staging/~facundo/magicicada-client/new-trash |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Natalia Bidart | Approve | ||
|
Review via email:
|
|||
Commit message
Start using a new way to send to trash, going away from Gnome.
Description of the change
Start using a new way to send to trash, going away from Gnome.
Now we start using a package installed in a virtualenv, so I normalized some stuff around it:
- create it at bootstrap time, not everytime on every make test
- install packages listed in requirements-
- pinpointed flake8 in the requirements, and removed it as a system dependency
Also cleaned up the `run-tests` script:
- no more building when running tests, only at bootstrap
- run u1trial from inside the venv
- removed quotes around $MODULE, so we can do now
./run-tests -t TestClass.test_foo tests/test_bleh.py
Start using a new way to send to trash, going away from Gnome.
Now we start using a package installed in a virtualenv, so I normalized some stuff around it:
- create it at bootstrap time, not everytime on every make test
- install packages listed in requirements-
- pinpointed flake8 in the requirements, and removed it as a system dependency
Also cleaned up the `run-tests` script:
- no more building when running tests, only at bootstrap
- run u1trial from inside the venv
- removed quotes around $MODULE, so we can do now
./run-tests -t TestClass.test_foo tests/test_bleh.py
Looks great! Thanks