Merge lp://staging/~facelessuser/beautifulsoup/linkage-performance-fix into lp://staging/beautifulsoup
Proposed by
Isaac Muse
| Status: | Merged | ||||
|---|---|---|---|---|---|
| Merge reported by: | Leonard Richardson | ||||
| Merged at revision: | not available | ||||
| Proposed branch: | lp://staging/~facelessuser/beautifulsoup/linkage-performance-fix | ||||
| Merge into: | lp://staging/beautifulsoup | ||||
| Diff against target: |
158 lines (+41/-98) 1 file modified
bs4/__init__.py (+41/-98) |
||||
| To merge this branch: | bzr merge lp://staging/~facelessuser/beautifulsoup/linkage-performance-fix | ||||
| Related bugs: |
|
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Leonard Richardson | Approve | ||
|
Review via email:
|
|||
Commit message
Fix for linkage performance.
This fixes performance with the recent linkage fixes in html5lib.
The code has been boiled down to the necessities of what is needed.
This will no longer aggressively check links down tree paths that
are unrelated.
Description of the change
This was almost the death of me getting this down the minimum required changes :).
Timing should once again be comparable with with 4.6.3.
Sorry I didn't get it right the first time. Hopefully relaxing the checks won't allow new html5lib issues, but performance is important as well.
To post a comment you must log in.
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
Getting the html5lib integration working right is really tough and I'm grateful that you've taken the time to do this work.