Screenshot

Merge lp://staging/~fabiozaramella/screenshot-tool/minor-fixes into lp://staging/~elementary-apps/screenshot-tool/trunk

  1. minor-fixes
  2. Merge into trunk
Proposed by Fabio Zaramella
Status: Merged
Approved by: Danielle Foré
Approved revision: 302
Merged at revision: 299
Proposed branch: lp://staging/~fabiozaramella/screenshot-tool/minor-fixes
Merge into: lp://staging/~elementary-apps/screenshot-tool/trunk
Diff against target: 59 lines (+14/-2)
2 files modified
src/Screenshot.vala (+2/-1)
src/ScreenshotWindow.vala (+12/-1)
To merge this branch: bzr merge lp://staging/~fabiozaramella/screenshot-tool/minor-fixes
Reviewer Review Type Date Requested Status
Fabio Zaramella (community) Needs Resubmitting
Danielle Foré Needs Fixing
Adam Bieńkowski (community) code Needs Information
Review via email: mp+317555@code.staging.launchpad.net

Commit message

* Hide main window behind save dialog when app is launched from command
* Show main window after window not found error

Description of the change

Hides main window behind save dialog when app is launched from command

To post a comment you must log in.
Revision history for this message
Adam Bieńkowski (donadigo) wrote :

Hm, is there a reason for the change on diff line 9? The condition now seems wrong for me.

review: Needs Information (code)
lp://staging/~fabiozaramella/screenshot-tool/minor-fixes updated
301. By Fabio Zaramella

Correct wrongly changed condition

Revision history for this message
Fabio Zaramella (fabiozaramella) wrote :

Ops, you're right. I changed it and didn't noticed. Thank you :)

review: Needs Resubmitting
Revision history for this message
Danielle Foré (danrabbit) wrote :

This branch makes it so I can't capture "windowed" screenshots of the panel indicators

review: Needs Fixing
lp://staging/~fabiozaramella/screenshot-tool/minor-fixes updated
302. By Fabio Zaramella

revert behaviour, allow avery type of windows

Revision history for this message
Fabio Zaramella (fabiozaramella) wrote :

You're right Daniel. Unfortunately this prevent popover to be captured, so I'll leave it as it was.

review: Needs Resubmitting

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: