Maya

Merge lp://staging/~fabiozaramella/maya/UI-improvements into lp://staging/~elementary-apps/maya/trunk

  1. UI-improvements
  2. Merge into trunk
Proposed by Fabio Zaramella
Status: Superseded
Proposed branch: lp://staging/~fabiozaramella/maya/UI-improvements
Merge into: lp://staging/~elementary-apps/maya/trunk
Diff against target: 221 lines (+46/-17)
8 files modified
po/maya-calendar.pot (+7/-3)
src/Application.vala (+1/-1)
src/EventEdition/EventDialog.vala (+12/-2)
src/EventEdition/GuestsPanel.vala (+9/-5)
src/EventEdition/InfoPanel.vala (+4/-2)
src/EventEdition/LocationPanel.vala (+5/-2)
src/EventEdition/ReminderPanel.vala (+7/-2)
src/SourceDialog.vala (+1/-0)
To merge this branch: bzr merge lp://staging/~fabiozaramella/maya/UI-improvements
Reviewer Review Type Date Requested Status
Corentin Noël Needs Fixing
AnSukkal (community) testing Approve
Review via email: mp+232588@code.staging.launchpad.net
To post a comment you must log in.
lp://staging/~fabiozaramella/maya/UI-improvements updated
628. By Fabio Zaramella

useless code removed

629. By Fabio Zaramella

added margin for cancel button in Calendar popover

630. By Fabio Zaramella

fixed reminders margin

Revision history for this message
AnSukkal (ansukkal) :
review: Approve (testing)
Revision history for this message
Corentin Noël (tintou) wrote :

I'm okay with the removal of the close button from the headerbar and the addition of a close button at the bottom, but I think that the switcher has to go into the headerbar and that the headerbar can keep its class.

review: Needs Fixing
lp://staging/~fabiozaramella/maya/UI-improvements updated
631. By Fabio Zaramella

switcher as custom toolbar

632. By Fabio Zaramella

cancel* button

Revision history for this message
Fabio Zaramella (fabiozaramella) wrote :

Is it ok now?

Revision history for this message
Corentin Noël (tintou) wrote :

It's almost there
I think that you should pack widgets into a Gtk.Frame instead of applying Gtk.STYLE_CLASS_ENTRY where it is not an input entry.

lp://staging/~fabiozaramella/maya/UI-improvements updated
633. By Fabio Zaramella

Gtk.Frame to pack elements in EventDialog

634. By Fabio Zaramella

code aligned correctly

635. By Fabio Zaramella

fix

Unmerged revisions

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches