Merge lp://staging/~evgeni/libappindicator/use-autoreconf.mk into lp://staging/~ubuntu-desktop/libappindicator/ubuntu

Proposed by Evgeni Golov
Status: Merged
Merged at revision: 296
Proposed branch: lp://staging/~evgeni/libappindicator/use-autoreconf.mk
Merge into: lp://staging/~ubuntu-desktop/libappindicator/ubuntu
Diff against target: 24 lines (+2/-2)
1 file modified
debian/rules (+2/-2)
To merge this branch: bzr merge lp://staging/~evgeni/libappindicator/use-autoreconf.mk
Reviewer Review Type Date Requested Status
Robert Ancell Approve
Ken VanDine Pending
Review via email: mp+106750@code.staging.launchpad.net

Description of the change

  use autoreconf.mk instead of calling dh_autoreconf by hand

  - fixes FTBFS when there are multiple Python versions
    (dh_autoreconf would be called multiple times in this case, which isn't
     allowed)
  - properly cleans autoreconf'ed files in the clean target
  - patchsys-quilt.mk needs to be included *before* autoreconf.mk or
    debhelper will leave uncleaned files in debian/, leading to
    E: libappindicator source: temporary-debhelper-file
       python-appindicator.debhelper.log and 9 others
    from lintian

To post a comment you must log in.
Revision history for this message
Robert Ancell (robert-ancell) wrote :

Looks good, uploaded to quantal.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: