Merge lp://staging/~evfool/update-manager/fix665173 into lp://staging/update-manager

Thanks for your contribution. The patch looks okay to me (although I cannot upload it). Have you tried to add a test for this situation?

Hmm, I guess the only problem could be that if one changelog source gave an HTTPError and then another source gave an BadStatusLine error (for example), you'd only see one of the two error messages, but maybe that's not terrible. If you were to get both errors, you've definitely got problems. ;)

I have tested it manually on a source not supporting changelogs, and the message is only shown once, as expected. Do you mean a unit-test? I think I could do that with a hard-coded launchpad changelog URL, that reports that changelogs are not supported. I'll check, I haven't written any Python unit-tests so fat, but I assume that the right place for this would be another method in the tests/test_changelog.py

> I have tested it manually on a source not supporting changelogs, and the
> message is only shown once, as expected. Do you mean a unit-test? I think I
> could do that with a hard-coded launchpad changelog URL, that reports that
> changelogs are not supported. I'll check, I haven't written any Python unit-
> tests so fat, but I assume that the right place for this would be another
> method in the tests/test_changelog.py

I think that would be a good place for it. There should be lots of examples in the package to cargo cult from :). Give it a shot! Thanks.

Really simple unittest added to check if the error message gets only once in the changelog. The package name is hardcoded for a package I have found that does not support changelogs, but not everyone will have that package though, so it could be replaced with a better package.

Maybe mvo has some thoughts about that. The indentation looks a little weird in the merge proposal, but if the test passes for you then I think it's good. Let's see what Michael has to say. Thanks for doing this!

The requested changes have been commited.

Hello! Thanks a lot for this branch (and the other branches!). Its getting a bit late here, but I will definitely merge this tonight or tomorrow.

Thanks a bunch, merged (I modified the unittest a bit to make it not depend on a sources.list entry that has liboverlay-scrollbar-0.1-0