Merge lp://staging/~evfool/software-properties/fixes into lp://staging/software-properties

Proposed by Robert Roth
Status: Merged
Merged at revision: 724
Proposed branch: lp://staging/~evfool/software-properties/fixes
Merge into: lp://staging/software-properties
Diff against target: 186 lines (+62/-22)
6 files modified
add-apt-repository (+34/-9)
data/com.ubuntu.softwareproperties.policy.in (+1/-1)
data/gtkbuilder/main.ui (+1/-1)
debian/manpages/add-apt-repository.1 (+20/-8)
softwareproperties/gtk/DialogMirror.py (+1/-1)
softwareproperties/gtk/SoftwarePropertiesGtk.py (+5/-2)
To merge this branch: bzr merge lp://staging/~evfool/software-properties/fixes
Reviewer Review Type Date Requested Status
Michael Vogt (community) Approve
Review via email: mp+79472@code.staging.launchpad.net

Description of the change

This branch contains the following minor fixes, one commit/bug
* Fix warnings logged to terminal about inexistent handlers by checking if the handlers exist
* Change geeky authentication text displayed on policykit auth dialog to the one suggested by mpt (bug #828285 )
* Reset the popcon checkbox value if changed, but auth failed (bug #874759)
* Apt-add-repository --remove changed to also remove the debsrc line (bug #838507)
* Apt-add-repository PPA warning changed to warn you about add/removal depending on what you really want to do.
* Update the manpage of apt-add-repository with the available options. (bug #697546)
* Reset the text on the mirror testing dialog after closing/canceling it (bug #875679)
* Unicode encode PPA description and displaynam to avoid UnicodeDecodeErrors (bug #827355)
* Do not expand the server combobox (bug #875131)

To post a comment you must log in.
729. By Robert Roth

Updated add-apt-repository manpage with new options

730. By Robert Roth

Reset dialog text after closing or canceling the test dialog (LP: #875679)

731. By Robert Roth

Fix UnicodeDecodeErrors caused by PPA displayname or description (LP: #827355)

732. By Robert Roth

Do not expand the Download From combo vertically (LP: #875131)

Revision history for this message
Michael Vogt (mvo) wrote :

Thanks a *bunch*, that is excellent work!

review: Approve
Revision history for this message
Michael Vogt (mvo) wrote :

Btw, some of this we should consider to backport to oneiric, actually everything that does not change strings. What do you think?

Revision history for this message
Robert Roth (evfool) wrote :

Yes, it's possible. Revisions 724, 726, 727, 730, 731, 732 are backportable, those do not contain any man page or string changes.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to status/vote changes: