Merge lp://staging/~evfool/software-center/lp752376 into lp://staging/software-center
Proposed by
Robert Roth
| Status: | Merged | ||||
|---|---|---|---|---|---|
| Merged at revision: | 3025 | ||||
| Proposed branch: | lp://staging/~evfool/software-center/lp752376 | ||||
| Merge into: | lp://staging/software-center | ||||
| Diff against target: |
78 lines (+43/-0) 2 files modified
softwarecenter/ui/gtk3/app.py (+7/-0) test/gtk3/test_app.py (+36/-0) |
||||
| To merge this branch: | bzr merge lp://staging/~evfool/software-center/lp752376 | ||||
| Related bugs: |
|
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| software-store-developers | Pending | ||
|
Review via email:
|
|||
Description of the change
Updated the code to also work with file:// style deb filenames, as requested in LP #752376, also added a unittest to check if the DebFileApplication is loaded after startup.
To post a comment you must log in.
Revision history for this message
| Michael Vogt (mvo) wrote | # |
Revision history for this message
| Robert Roth (evfool) wrote | # |
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
Thanks a lot for this branch, its really great to see all your work around software-center!
It looks great there are two small issues:
- the file:// should probably start with file:/ just to ensure that the widest possible range if covered, I think some file managers pass file:/, file:// or even file:///
- the regexp is ideally updated as well for this as the prefix already includes the // so the regexp is not matching exactly what we need here. we can probably simplify it quite a bit and just use "os.path.normpath" after removing the prefix "file:/" to cover prefixed "/".
It would be great if you could have a look, but I'm happy to work on this later today too if you are busy.