Ubuntu Software Center

Merge lp://staging/~evfool/software-center/lp1076189 into lp://staging/software-center

  1. lp1076189
  2. Merge into trunk
Proposed by Robert Roth
Status: Merged
Approved by: Michael Vogt
Approved revision: 3293
Merged at revision: 3297
Proposed branch: lp://staging/~evfool/software-center/lp1076189
Merge into: lp://staging/software-center
Diff against target: 19 lines (+0/-2)
1 file modified
data/ui/sso/sso.ui (+0/-2)
To merge this branch: bzr merge lp://staging/~evfool/software-center/lp1076189
Reviewer Review Type Date Requested Status
Michael Vogt (community) Approve
dobey Approve
Review via email: mp+149965@code.staging.launchpad.net

This proposal supersedes a proposal from 2013-02-12.

Commit message

- Remove foo tooltip from sso login and forgot password button. (LP: #1076189)

Description of the change

- Remove foo tooltip from sso login and forgot password button (LP: #1076189)

Simple and clean merge to remove 'foo' displayed as tooltip for the SSO login and forgot password linkbuttons. The reason was that the uri was set to foo, and linkbutttons display by default the uri as tooltip. Foo is not a useful link anyway, so we can safely remove that.

To post a comment you must log in.
Revision history for this message
Michael Vogt (mvo) wrote : Posted in a previous version of this proposal

Thanks for this fix. Looks good.

Please also add a commit message so that it can be auto-merged.

review: Approve
Revision history for this message
Robert Roth (evfool) wrote : Posted in a previous version of this proposal

Done, set a commit message.

Revision history for this message
dobey (dobey) wrote : Posted in a previous version of this proposal

The commit has no author/committer name and e-mail address associated with it. The commit needs to have an e-mail address which you have associated with your Launchpad account, as the author. Please resubmit a branch with a proper commit, thanks.

review: Needs Resubmitting
Revision history for this message
Robert Roth (evfool) wrote : Posted in a previous version of this proposal

Bzr whoami correctly returns my name and email address (one which I do have set in my launchpad account - although not as default). All my previous merge proposals have been accepted with exactly the same info, same bzr info, same commit settings, same workflow. Could you please help me a bit on how to add a "proper" commit? Thanks in advance.

Revision history for this message
Robert Roth (evfool) wrote : Posted in a previous version of this proposal

OK. Don't know what was wrong with bzr, but somehow commit info was not correctly recorded. I have checked out the branch, uncommit, commit again, push back, and now committer info is OK.

Revision history for this message
dobey (dobey) :
review: Approve
Revision history for this message
dobey (dobey) wrote :

Michael, can you do a quick re-review of this please? Thanks.

Revision history for this message
Michael Vogt (mvo) wrote :

Sure! I didn't notice that the resubmit invalided my previous approve. Approved again now.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.