Midori Web Browser

Merge lp://staging/~evfool/midori/coretransfer into lp://staging/midori

  1. coretransfer
  2. Merge into trunk
Proposed by Robert Roth
Status: Needs review
Proposed branch: lp://staging/~evfool/midori/coretransfer
Merge into: lp://staging/midori
Diff against target: 950 lines (+295/-213)
9 files modified
extensions/transfers.vala (+41/-117)
midori/midori-browser.c (+52/-38)
midori/midori-tab.vala (+9/-0)
midori/midori-transfer.vala (+163/-0)
midori/midori-view.c (+24/-58)
midori/midori.vapi (+1/-0)
midori/webkit2gtk-3.0.vapi (+3/-0)
midori/webkitgtk-3.0.vapi (+1/-0)
po/POTFILES.in (+1/-0)
To merge this branch: bzr merge lp://staging/~evfool/midori/coretransfer
Reviewer Review Type Date Requested Status
Cris Dywan Pending
Review via email: mp+224237@code.staging.launchpad.net

Commit message

Move Transfer API into the core

Description of the change

This branch moves the Transfer object from the Transfers extension to midori core to be able to use it in other extensions too.

To post a comment you must log in.
lp://staging/~evfool/midori/coretransfer updated
6724. By Robert Roth

Added copyright header to transfer file

6725. By Robert Roth

Merged from trunk

6726. By Robert Roth

Add the add-download signal back for backwards-compatibility

6727. By Robert Roth

Use return_if_fail instead of nullchecks

Revision history for this message
Robert Roth (evfool) wrote :

Branch updated according to IRC review from Kalikiana:
* copyright header added to new file (midori-transfer.vala)
* instead of null-check use return_if_fail
* keep backwards compatibility by also emitting the old add-download signal for plugins until they migrate to using add-transfer

Reply
lp://staging/~evfool/midori/coretransfer updated
6728. By Robert Roth

Fixed critical warning: the mimetype decision callback starts the download, do not start it twice

6729. By Robert Roth

Fixed Webkit2 build failures

Revision history for this message
Robert Roth (evfool) wrote :

Updated branch based on second IRC review from kalikiana:
* webkit2 build failure fixed
* webkit critical fixed by starting download only once

Reply
lp://staging/~evfool/midori/coretransfer updated
6730. By Robert Roth

Destroy the save as dialog to avoid GTK3 crash

Revision history for this message
Robert Roth (evfool) wrote :

Destroy the save as dialog instead of hiding it to avoid crash from GTK3 filechooser similar to https://bugzilla.gnome.org/show_bug.cgi?id=726857 or https://bugzilla.redhat.com/show_bug.cgi?id=1086403

Reply

Unmerged revisions

6730. By Robert Roth

Destroy the save as dialog to avoid GTK3 crash

6729. By Robert Roth

Fixed Webkit2 build failures

6728. By Robert Roth

Fixed critical warning: the mimetype decision callback starts the download, do not start it twice

6727. By Robert Roth

Use return_if_fail instead of nullchecks

6726. By Robert Roth

Add the add-download signal back for backwards-compatibility

6725. By Robert Roth

Merged from trunk

6724. By Robert Roth

Added copyright header to transfer file

6723. By Robert Roth

Add safety checks to transfer renderer methods

6722. By Robert Roth

Start transfer with the transfer object instead of the download object

6721. By Robert Roth

Moved transfer object to the core (lp:888396)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: