juju-quickstart

Merge lp://staging/~evarlast/juju-quickstart/upload-tools-constraints into lp://staging/juju-quickstart

upload-tools-constraints
Merge into trunk

Proposed by Jay R. Wren on 2014-07-17

Status:	Merged
Merged at revision:	91
Proposed branch:	lp://staging/~evarlast/juju-quickstart/upload-tools-constraints
Merge into:	lp://staging/juju-quickstart
Diff against target:	202 lines (+91/-10) 4 files modified quickstart/app.py (+10/-1) quickstart/manage.py (+24/-3) quickstart/tests/test_app.py (+36/-0) quickstart/tests/test_manage.py (+21/-6)
To merge this branch:	bzr merge lp://staging/~evarlast/juju-quickstart/upload-tools-constraints
Related bugs:	Link a bug report

Reviewer	Review Type	Date Requested	Status
Francesco Banconi		2014-07-17	Approve on 2014-08-19
Review via email: mp+227229@code.staging.launchpad.net

Description of the change

support upload-tools and upload-series

support pass through of --upload-tools --upload-series and --constraints from quickstart to bootstrap

https://bugs.launchpad.net/juju-quickstart/+bug/1274584

https://codereview.appspot.com/132760043/

Revision history for this message

Francesco Banconi (frankban) wrote on 2014-07-18:

Nice branch Jay, it looks good with some changes I described below.
Thank you!

lp://staging/~evarlast/juju-quickstart/upload-tools-constraints updated on 2014-08-01

91. By Jay R. Wren on 2014-08-01: addressing review concerns

Revision history for this message

Francesco Banconi (frankban) wrote on 2014-08-19:

LGTM with minor changes, thank you!

review: Approve

lp://staging/~evarlast/juju-quickstart/upload-tools-constraints updated on 2014-08-21

92. By Jay R. Wren on 2014-08-21: semicolons and periods in comments

Revision history for this message

Jay R. Wren (evarlast) wrote on 2014-08-21:

Reviewers: mp+227229_code.launchpad.net,

Message:
Please take a look.

Description:
support upload-tools and upload-series

support pass through of --upload-tools --upload-series and --constraints
from quickstart to bootstrap

https://bugs.launchpad.net/juju-quickstart/+bug/1274584

https://code.launchpad.net/~evarlast/juju-quickstart/upload-tools-constraints/+merge/227229

(do not edit description out of merge proposal)

Please review this at https://codereview.appspot.com/132760043/

Affected files (+93, -10 lines):
   A [revision details]
   M quickstart/app.py
   M quickstart/manage.py
   M quickstart/tests/test_app.py
   M quickstart/tests/test_manage.py