Juju Charms Collection
mediawiki package

Merge lp://staging/~evarlast/charms/trusty/mediawiki/trusty-port into lp://staging/charms/mediawiki

  1. Trusty Tahr (14.04)
  2. trusty-port
  3. Merge into trunk
Proposed by Jay R. Wren
Status: Rejected
Rejected by: José Antonio Rey
Proposed branch: lp://staging/~evarlast/charms/trusty/mediawiki/trusty-port
Merge into: lp://staging/charms/mediawiki
Diff against target: 75 lines (+14/-9)
3 files modified
hooks/config-changed (+2/-6)
hooks/db-relation-changed (+1/-1)
hooks/install (+11/-2)
To merge this branch: bzr merge lp://staging/~evarlast/charms/trusty/mediawiki/trusty-port
Reviewer Review Type Date Requested Status
José Antonio Rey (community) Disapprove
Adam Israel (community) Needs Fixing
Review via email: mp+226752@code.staging.launchpad.net

Description of the change

Make it work with trusty.

To post a comment you must log in.
Revision history for this message
Jorge Castro (jorge) wrote :

Can we just remove the PPA entirely before promoting this to trusty?

Revision history for this message
Jay R. Wren (evarlast) wrote :

I did not test that at all. I'll test it and see if it works.

On Tue, Jul 29, 2014 at 3:58 PM, Jorge O. Castro <email address hidden> wrote:

> Can we just remove the PPA entirely before promoting this to trusty?
> --
>
> https://code.launchpad.net/~evarlast/charms/trusty/mediawiki/trusty-port/+merge/226752
> You are the owner of lp:~evarlast/charms/trusty/mediawiki/trusty-port.
>

lp://staging/~evarlast/charms/trusty/mediawiki/trusty-port updated
81. By Jay R. Wren

ppa is no longer needed

With the changes for trusty, the precise ppa is no longer needed.

Revision history for this message
Jay R. Wren (evarlast) wrote :

Removed PPA entirely. Tested to confirm that this works with precise.

Revision history for this message
Adam Israel (aisrael) wrote :

Hey Jay,

Thanks for sending this in.

In reviewing this, I found that the DocumentRoot wasn't quite being updated correctly. The path was set to '/usr/share/mediawiki/html', but should be set to '/usr/share/mediawiki'.

Other than that, the charm works for me.

review: Needs Fixing
Revision history for this message
Adam Israel (aisrael) wrote :

Hey Jay,

I went ahead and made a merge to fix your merge.

https://code.launchpad.net/~aisrael/charms/trusty/mediawiki/trusty-port/+merge/233656

Revision history for this message
José Antonio Rey (jose) wrote :

This MP is currently superseded by aisrael's (https://code.launchpad.net/~aisrael/charms/trusty/mediawiki/trusty-port/+merge/233656), which also contain these changes. Thanks for your efforts in the MediaWiki charm, Jay! :)

review: Disapprove
Revision history for this message
Jay R. Wren (evarlast) wrote :

Huge thanks for that Adam. I was unable to do it in a timely manner.

On Sun, Sep 7, 2014 at 10:41 PM, José Antonio Rey <email address hidden> wrote:

> The proposal to merge lp:~evarlast/charms/trusty/mediawiki/trusty-port
> into lp:charms/mediawiki has been updated.
>
> Status: Needs review => Rejected
>
> For more details, see:
>
> https://code.launchpad.net/~evarlast/charms/trusty/mediawiki/trusty-port/+merge/226752
> --
>
> https://code.launchpad.net/~evarlast/charms/trusty/mediawiki/trusty-port/+merge/226752
> You are the owner of lp:~evarlast/charms/trusty/mediawiki/trusty-port.
>

Unmerged revisions

81. By Jay R. Wren

ppa is no longer needed

With the changes for trusty, the precise ppa is no longer needed.

80. By Jay R. Wren

fix install

79. By Jay R. Wren

trusty fixes for mediawiki

This charm was only working by chance. The sed -ie was making
backup files in apache conf dir. Those files were being read, hence
the attempted toggle DocumentRoot was a no-op or inverse.

clint-fewbar/fixes ppa does not exist for trusty, and is not needed.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: