Merge lp://staging/~ev/whoopsie/android-serial into lp://staging/whoopsie

Proposed by Evan
Status: Rejected
Rejected by: John Lenton
Proposed branch: lp://staging/~ev/whoopsie/android-serial
Merge into: lp://staging/whoopsie
Diff against target: 103 lines (+39/-0)
4 files modified
Makefile (+2/-0)
debian/changelog (+7/-0)
debian/control (+1/-0)
src/identifier.c (+29/-0)
To merge this branch: bzr merge lp://staging/~ev/whoopsie/android-serial
Reviewer Review Type Date Requested Status
Canonical Foundations Team system identifier composition Pending
Daisy Pluckers Pending
Review via email: mp+178306@code.staging.launchpad.net

Description of the change

Uses libandroid-properties to use the Android serial number, manufacturer, model, and board as the system identifier (falling back to the first non-loopback MAC address).

Feedback on the selection of hardware-static strings welcome. I'm trying to seed the sha512sum with sufficient data to create a low risk for collision.

To post a comment you must log in.
567. By Evan

Use a bit more information on Android to seed the sha512.

568. By Evan

Use the board on Android as part of the identitifer.

569. By Evan

Typo.

570. By Evan

Fix changelog entry.

571. By Evan

update the docstring one last time.

Revision history for this message
Dimitri John Ledkov (xnox) wrote :

For devices that have sim card capability, they also have IMEI number assigned (world-wide unique across all devices), which is used by SIM cards when authenticating with 3G and GSM networks. It's used to blacklist stolen devices and make them essentially bricks (well, not able to authenticate with 3G/GSM). Thus if available that should be used to uniquely identify the device in-additionto/instead of proposed methods. IMEI is also android independant and portable between all devices that have sim cards (Eg. laptops with sim cards).

Ubuntu System Settings already has methods to fetch IMEI number.

Revision history for this message
Evan (ev) wrote :

Following what @xnox said, ubuntu-system-settings uses the QtMobility APIs to fetch the IMEI number. This in turn seems to use NetworkManager's DBus API to find the first GSM device and return its IMEI:

http://www.qt.gitorious.org/qt-mobility/qt-mobility/blobs/master/src/systeminfo/linux/qsysteminfo_linux.cpp#line471

Revision history for this message
Evan (ev) wrote :

ofono does provide us with an interface to the IMEI, but it's currently broken in the case when there's no SIM inserted:

https://bugs.launchpad.net/ubuntu/+source/ofono/+bug/1210502

Revision history for this message
Evan (ev) wrote :

It's been pointed out by Adam that we probably want to concatenate the IMEI with some other data, like the MAC address, if we are to use it. An IMEI doesn't give you a particularly large range.

Revision history for this message
John Lenton (chipaca) wrote :

For the record, this work and ensuing comments was the starting point for https://code.launchpad.net/~chipaca/whoopsie/brofono which has now landed.

Revision history for this message
John Lenton (chipaca) wrote :

(setting it to "rejected" because people keep on asking when this branch is going to land...)

Unmerged revisions

571. By Evan

update the docstring one last time.

570. By Evan

Fix changelog entry.

569. By Evan

Typo.

568. By Evan

Use the board on Android as part of the identitifer.

567. By Evan

Use a bit more information on Android to seed the sha512.

566. By Evan

Use the Android serial number for a system identifier, if it is
available.

565. By Evan

libandroid-properties-dev build-dep.

564. By Evan

Comment.

563. By Evan

Once more, without the memory corruption.

562. By Evan

Initial commit of work to use the android serial number as the crash db identifier.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes:
to status/vote changes: