Merge lp://staging/~ev/uci-engine/skipped-integration-tests into lp://staging/uci-engine
- skipped-integration-tests
- Merge into trunk
Status: | Needs review |
---|---|
Proposed branch: | lp://staging/~ev/uci-engine/skipped-integration-tests |
Merge into: | lp://staging/uci-engine |
Diff against target: |
26 lines (+3/-2) 2 files modified
bin/called-by-tarmac.py (+1/-1) testing/run_tests.py (+2/-1) |
To merge this branch: | bzr merge lp://staging/~ev/uci-engine/skipped-integration-tests |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Francis Ginther | Approve | ||
PS Jenkins bot (community) | continuous-integration | Approve | |
Review via email: mp+242027@code.staging.launchpad.net |
Commit message
Raise an error when the integration tests are skipped and --no-skip was provided. Call run-tests with --no-skip under tarmac.
Description of the change
PS Jenkins bot (ps-jenkins) wrote : | # |
Francis Ginther (fginther) wrote : | # |
Looks good. Let's see what get's skipped!
Ubuntu CI Bot (uci-bot) wrote : | # |
The attempt to merge lp:~ev/uci-engine/skipped-integration-tests into lp:uci-engine failed. Below is the output from the failed tests.
Running cm...
Updating source dependencies...
Updating source dependencies...
Updating source dependencies...
Updating source dependencies...
Updating source dependencies...
Updating source dependencies...
uploading webui-content.tgz to swift
Updating source dependencies...
Checking juju status
Private PPAs: disabled
Preparing local branch upload...
Uploading local branch, fingerprint 66ade962a9fce51
Building charm: lander
Building charm: wsgi-app
Building charm: rabbitmq-worker
Building charm: chroot-builder
Building charm: key-secret-
Building charm: webui
Building charm: system-image-server
Installing keys from bzr+ssh:
Running juju-deployer -v -c /tmp/tmpRCdPbG/
Tests running...
ci-utils.
ci-utils.
ci-utils.
ci-utils.
ci-utils.
ci-utils.
ci-utils.
ci-utils.
ci-utils.
ci-utils.
ci-utils.
ci-utils.
ci-utils.
ci-utils.
ci-utils.
ci-utils.
ci-utils.
ci-utils.
ci-utils.
Vincent Ladeuil (vila) wrote : | # |
=======
FAIL: tests.test_
-------
Traceback (most recent call last):
File "/tmp/tarmac/
assertions.
File "/dev/shm/
' for {!r}'.format(
File "/usr/lib/
raise self.failureExc
AssertionError: Incorrect length: wanted 6, got 3 for [{u'progress_
Ran 728 tests in 450.880s
FAILED (failures=1)
[2014-11-19 09:22:14,215] image_test:
[2014-11-19 09:22:14,216] image_test:
[2014-11-19 09:22:41,303] image_test:INFO:Got IP 172.19.0.166 for faf4507b-
[2014-11-19 09:42:45,349] image_test:
Traceback (most recent call last):
File "./test_
File "/srv/ci-
self.
File "/srv/ci-
raise TestBedExceptio
TestBedException: Instance never completed cloud-init
[2014-11-19 09:42:45,502] image_test:
Vincent Ladeuil (vila) wrote : | # |
Top-approving again hoping for the transient failure to go away so that the --no-skip check can trigger and answer Francis's:
> Looks good. Let's see what get's skipped!
I expect a bunch of test runner tests (at least).
Ubuntu CI Bot (uci-bot) wrote : | # |
The attempt to merge lp:~ev/uci-engine/skipped-integration-tests into lp:uci-engine failed. Below is the output from the failed tests.
Running cm...
Updating source dependencies...
Updating source dependencies...
Updating source dependencies...
Updating source dependencies...
Updating source dependencies...
Updating source dependencies...
uploading webui-content.tgz to swift
Updating source dependencies...
Checking juju status
Private PPAs: disabled
Preparing local branch upload...
Uploading local branch, fingerprint 7c380ec060f9691
Building charm: lander
Building charm: wsgi-app
Building charm: rabbitmq-worker
Building charm: chroot-builder
Building charm: key-secret-
Building charm: webui
Building charm: system-image-server
Installing keys from bzr+ssh:
Running juju-deployer -v -c /tmp/tmpxMlF7y/
Tests running...
ci-utils.
ci-utils.
ci-utils.
ci-utils.
ci-utils.
ci-utils.
ci-utils.
ci-utils.
ci-utils.
ci-utils.
ci-utils.
ci-utils.
ci-utils.
ci-utils.
ci-utils.
ci-utils.
ci-utils.
ci-utils.
ci-utils.
Para Siva (psivaa) wrote : | # |
Where is the failure?.
...
Ran 728 tests in 476.376s
OK
...
Vincent Ladeuil (vila) wrote : | # |
Ran 728 tests in 476.376s
OK
Epic fail ;)
--no-skip should at least gives some feedback that the test run has failed and better, output the names of the skipped tests.
britney_
britney_
britney_
britney_
test_runner.
test_runner.
test_runner.
test_runner.
test_runner.
test_runner.
test_runner.
test_runner.
test_runner.
test_runner.
test_runner.
test_runner.
test_runner.
test_runner.
test_runner.
test_runner.
test_runner.
PASSED: Continuous integration, rev:897 s-jenkins. ubuntu- ci:8080/ job/uci- engine- ci/1720/
http://
Executed test runs:
Click here to trigger a rebuild: s-jenkins. ubuntu- ci:8080/ job/uci- engine- ci/1720/ rebuild
http://