Merge lp://staging/~ev/ubuntu-ci-services-itself/time-sorted-tests into lp://staging/ubuntu-ci-services-itself
| Status: | Merged |
|---|---|
| Approved by: | Evan |
| Approved revision: | 410 |
| Merged at revision: | 402 |
| Proposed branch: | lp://staging/~ev/ubuntu-ci-services-itself/time-sorted-tests |
| Merge into: | lp://staging/ubuntu-ci-services-itself |
| Diff against target: |
213 lines (+122/-7) 7 files modified
bin/test_time_sorted_tests.py (+32/-0) bin/time_sorted_tests.py (+67/-0) branch-source-builder/bsbuilder/tests/test_upload.py (+3/-1) branch-source-builder/bsbuilder/tests/test_v1.py (+3/-1) ci-utils/ci_utils/image_store/tests/test-image-store.py (+6/-1) ci-utils/ci_utils/tests/test_amqp.py (+3/-3) lander/lander/tests/test_archiver.py (+8/-1) |
| To merge this branch: | bzr merge lp://staging/~ev/ubuntu-ci-services-itself/time-sorted-tests |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Andy Doan (community) | Approve | ||
| Chris Johnston (community) | Approve | ||
| PS Jenkins bot (community) | continuous-integration | Approve | |
|
Review via email:
|
|||
Commit message
Shave two minutes off test execution. Add a small program to print sorted test execution time.
Description of the change
The kinds of things one discovers while on a ten hour flight. This branch knocks our worst case test time under ./run-tests from 2 minutes 12 seconds to 10 seconds. A few tests were setting up nonexistent hosts to talk to, then waiting for the socket timeout:
trunk:
Ran 289 tests in 133.913s
Ran 289 tests in 132.474s
Ran 289 tests in 132.500s
time-sorted-tests:
Ran 289 tests in 10.384s
Ran 289 tests in 10.727s
Ran 289 tests in 10.676s
It also adds a small tested program to sort the tests by their execution time, which was helpful in identifying long running tests. We should run this periodically (say as part of the MP review toolbelt) to ensure that our ability to iterate quickly isn't slowed by our growing test coverage.
| PS Jenkins bot (ps-jenkins) wrote | # |
PASSED: Continuous integration, rev:410
http://
Executed test runs:
Click here to trigger a rebuild:
http://