Merge lp://staging/~ev/charms/precise/postgresql/non-fatal-sysctl into lp://staging/charms/postgresql
Proposed by
Evan
| Status: | Merged |
|---|---|
| Merged at revision: | 103 |
| Proposed branch: | lp://staging/~ev/charms/precise/postgresql/non-fatal-sysctl |
| Merge into: | lp://staging/charms/postgresql |
| Diff against target: |
13 lines (+2/-1) 1 file modified
hooks/hooks.py (+2/-1) |
| To merge this branch: | bzr merge lp://staging/~ev/charms/precise/postgresql/non-fatal-sysctl |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Stuart Bishop (community) | Approve | ||
|
Review via email:
|
|||
Description of the change
The postgresql charm fails to deploy under LXC when it tries to call sysctl. This branch makes the sysctl commands non-fatal on error.
To post a comment you must log in.
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
Thanks. This looks good.
My initial thought was that we should log a warning if sysctl failed, but I realized that it is unnecessary as we don't specify quiet=True in the call to run(), so errors are already being emitted to the logs.