ethan.hsieh

Merge ~ethan.hsieh/+git/u-boot:devel into ~ethan.hsieh/+git/u-boot:ubuntu/bionic-proposed

  1. Git
  2. lp:~ethan.hsieh/+git/u-boot
  3. devel
  4. Merge into ubuntu/bionic-proposed
Proposed by ethan.hsieh
Status: Needs review
Proposed branch: ~ethan.hsieh/+git/u-boot:devel
Merge into: ~ethan.hsieh/+git/u-boot:ubuntu/bionic-proposed
Diff against target: 42 lines (+7/-3)
2 files modified
configs/nitrogen6q2g_defconfig (+0/-2)
include/configs/nitrogen6x.h (+7/-1)
Reviewer Review Type Date Requested Status
Łukasz Zemczak (community) Approve
Dave Jones Pending
Shrirang Bagul Pending
ethan.hsieh Pending
Review via email: mp+377153@code.staging.launchpad.net
To post a comment you must log in.
Revision history for this message
ethan.hsieh (ethan.hsieh) wrote :

@Lukasz
I have no permission to send MP to https://code.launchpad.net/~usd-import-team/ubuntu/+source/u-boot/+git/u-boot/+ref/ubuntu/bionic-proposed
Could you help to review this patch?

Reply
Revision history for this message
ethan.hsieh (ethan.hsieh) wrote :

This patch is based on the following MP.
https://code.launchpad.net/~anthonywong/ubuntu/+source/u-boot/+git/u-boot/+merge/371860

Reply
Revision history for this message
Łukasz Zemczak (sil2100) wrote :

If I understand this correctly: since our u-boot isn't up-to-date, we're missing the 2 commits that migrate CONFIG_SYS_REDUNDAND_ENVIRONMENT (and others) to Kconfig, so those config changes were ignored on the defconfig.

This seems like a decent workaround for this, certainly feels safer than cherry-picking two rather big commits. Looks good to me.

review: Approve
Reply

There was an error fetching revisions from git servers. Please try again in a few minutes. If the problem persists, contact Launchpad support.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: