Merge ~enr0n/ubuntu/+source/cron:merge-mantic into ubuntu/+source/cron:debian/sid

I've also triggered the britney autopkgtests against the cron package in the PPA. Will followup with test results if they complete soonish, otherwise can retrieve them via ppa-dev-tools:

$ ppa tests ppa:enr0n/proposed-migration -p cron
* Triggers:
  - Source cron/3.0pl1-162ubuntu1~ppa2: Published
    + Trigger basic @amd64♻️ Trigger all-proposed @amd64💍
    + Trigger basic @arm64♻️ Trigger all-proposed @arm64💍
    + Trigger basic @armhf♻️ Trigger all-proposed @armhf💍
    + Trigger basic @i386♻️ Trigger all-proposed @i386💍
    + Trigger basic @ppc64el♻️ Trigger all-proposed @ppc64el💍
    + Trigger basic @s390x♻️ Trigger all-proposed @s390x💍
* Running:
  # time pkg release arch ppa trigger
  - 160 cron mantic amd64 enr0n/proposed-migration cron/3.0pl1-162ubuntu1~ppa2
  - 160 cron mantic i386 enr0n/proposed-migration cron/3.0pl1-162ubuntu1~ppa2
  - 160 cron mantic s390x enr0n/proposed-migration cron/3.0pl1-162ubuntu1~ppa2
  - 160 cron mantic armhf enr0n/proposed-migration cron/3.0pl1-162ubuntu1~ppa2
  - 160 cron mantic arm64 enr0n/proposed-migration cron/3.0pl1-162ubuntu1~ppa2
  - 160 cron mantic ppc64el enr0n/proposed-migration cron/3.0pl1-162ubuntu1~ppa2

Looks like the autopkgtest fix only works on amd64, so I will re-work that. Thanks for triggering those.

I. With dropped changes, a good practice to follow is to include a rationale for why it was dropped. I see what you mean about it no longer applying, and it looks like it's due to upstream cleanup work that removed the errant env vars in release 3.0pl1-136, so I'd suggest updating the changelog to:

  * Dropped changes, patch no longer applies:
    - Update crontab(5) manpage to match new behaviour
      [Fixed upstream in 3.0pl1-136.]

But that's just a nitpick. :-)

II. The rest of the packaging work looks solid, good job.

III. I ran your suggested test, creating a /usr/local/bin/test script and cronning it. I ran it both before upgrading to the PPA cron, and after, and verified that rebooting the container caused it to generate the /tmp/hello.txt file I expected. (I hadn't used @reboot in cron jobs before; nice, TIL!)

Btw, 'test' is probably a bad name to suggest for the test since there's a 'test' built-in for Bash already. :-)

IV. Unfortunately, there does seem to be an error with the updated autopkgtest:

  - cron/3.0pl1-162ubuntu1~ppa2
    + ✅ cron on mantic for amd64 @ 06.06.23 18:47:26 Log️ 🗒️
    + ❌ cron on mantic for arm64 @ 06.06.23 18:37:47 Log️ 🗒️
      • compare-with-old-cron-files FAIL 🟥
      • check-significant-header PASS 🟩
      • do-not-modify-previous-crontabs PASS 🟩
      • check-messages-sent-by-cron PASS 🟩
      • check-listings-protection PASS 🟩
    + ❌ cron on mantic for armhf @ 06.06.23 18:27:21 Log️ 🗒️
      • compare-with-old-cron-files FAIL 🟥
      • check-significant-header PASS 🟩
      • do-not-modify-previous-crontabs PASS 🟩
      • check-messages-sent-by-cron PASS 🟩
      • check-listings-protection PASS 🟩
    + ❌ cron on mantic for i386 @ 06.06.23 18:35:50 Log️ 🗒️
      • compare-with-old-cron-files FAIL 🟥
      • check-significant-header FAIL 🟥
      • do-not-modify-previous-crontabs FAIL 🟥
      • check-messages-sent-by-cron FAIL 🟥
      • check-listings-protection FAIL 🟥
    + ❌ cron on mantic for ppc64el @ 06.06.23 18:33:51 Log️ 🗒️
      • compare-with-old-cron-files FAIL 🟥
      • check-significant-header PASS 🟩
      • do-not-modify-previous-crontabs PASS 🟩
      • check-messages-sent-by-cron PASS 🟩
      • check-listings-protection PASS 🟩
    + ❌ cron on mantic for s390x @ 06.06.23 18:39:18 Log️ 🗒️
      • compare-with-old-cron-files FAIL 🟥
      • check-significant-header PASS 🟩
      • do-not-modify-previous-crontabs PASS 🟩
      • check-messages-sent-by-cron PASS 🟩
      • check-listings-protection PASS 🟩

The i386 failures are probably irrelevant, but the fails on the other architectures aren't. Looking at the log file for the armhf test:

### https://autopkgtest.ubuntu.com/results/autopkgtest-mantic-enr0n-proposed-migration/mantic/armhf/c/cron/20230606_182721_a02c9@/log.gz ###

+----------------------------------------------------------------------+
| this test has been designed to check that when one uses the new |
| package set, cron + cron-daemon-common, the installed |
| configuration files are the same than those wh...

Besides i386 (which I am ignoring), the autopkgtests look good now:

cron 3.0pl1-162ubuntu1~ppa3 (amd64) -- Pass: https://autopkgtest.ubuntu.com/results/autopkgtest-mantic-enr0n-proposed-migration/mantic/amd64/c/cron/20230606_203701_aa135@/log.gz
cron 3.0pl1-162ubuntu1~ppa3 (armhf) -- Pass: https://autopkgtest.ubuntu.com/results/autopkgtest-mantic-enr0n-proposed-migration/mantic/armhf/c/cron/20230606_204316_0792d@/log.gz
cron 3.0pl1-162ubuntu1~ppa3 (arm64) -- Pass: https://autopkgtest.ubuntu.com/results/autopkgtest-mantic-enr0n-proposed-migration/mantic/arm64/c/cron/20230606_204921_aa135@/log.gz
cron 3.0pl1-162ubuntu1~ppa3 (ppc64el) -- Pass: https://autopkgtest.ubuntu.com/results/autopkgtest-mantic-enr0n-proposed-migration/mantic/ppc64el/c/cron/20230606_205019_4133c@/log.gz
cron 3.0pl1-162ubuntu1~ppa3 (s390x) -- Pass: https://autopkgtest.ubuntu.com/results/autopkgtest-mantic-enr0n-proposed-migration/mantic/s390x/c/cron/20230606_212737_20639@/log.gz

I also added some more context to the changelog entry about the dropped patch.

Thanks, looks good. Upload sponsored:

Vcs-Git: https://git.launchpad.net/~bryce/ubuntu/+source/cron
Vcs-Git-Commit: 72ea84d47af8a68360f3ece054768df33de40298
Vcs-Git-Ref: refs/heads/merge-mantic

gpg: ../cron_3.0pl1-162ubuntu1_source.changes: Valid signature from E603B2578FB8F0FB
Checking signature on .dsc
gpg: ../cron_3.0pl1-162ubuntu1.dsc: Valid signature from E603B2578FB8F0FB
Uploading to ubuntu (via ftp to upload.ubuntu.com):
  Uploading cron_3.0pl1-162ubuntu1.dsc: done.
  Uploading cron_3.0pl1-162ubuntu1.debian.tar.xz: done.
  Uploading cron_3.0pl1-162ubuntu1_source.buildinfo: done.
  Uploading cron_3.0pl1-162ubuntu1_source.changes: done.
Successfully uploaded packages.

Thanks, Bryce!