Merge lp://staging/~embik/pantheon-calculator/gsettings into lp://staging/~elementary-apps/pantheon-calculator/trunk
Proposed by
Marvin Beckers
| Status: | Merged | ||||
|---|---|---|---|---|---|
| Approved by: | Marvin Beckers | ||||
| Approved revision: | 95 | ||||
| Merged at revision: | 96 | ||||
| Proposed branch: | lp://staging/~embik/pantheon-calculator/gsettings | ||||
| Merge into: | lp://staging/~elementary-apps/pantheon-calculator/trunk | ||||
| Prerequisite: | lp://staging/~embik/pantheon-calculator/bugfix-1413257 | ||||
| Diff against target: |
106 lines (+40/-4) 3 files modified
CMakeLists.txt (+3/-0) data/org.pantheon.calculator.gschema.xml (+20/-0) src/MainWindow.vala (+17/-4) |
||||
| To merge this branch: | bzr merge lp://staging/~embik/pantheon-calculator/gsettings | ||||
| Related bugs: |
|
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Cody Garver (community) | Approve | ||
|
Review via email:
|
|||
Commit message
added GSettings support (saving the current state of the calculator)
Description of the change
Added gschema file and gsettings to load and manipulate these settings:
- state of extended panel display
- decimal places (which are not changeable via the pantheon-calculator UI currently but may be later on)
- content of entry as pantheon-calculator has been closed the last time
These improvements should provide a better user experience as it saves the last state of use and complies therefore with the HIG (User Workflow -> Closing -> Saving State).
To post a comment you must log in.
Revision history for this message
| Cody Garver (codygarver) | # |
review:
Approve
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
