Ubuntu File Manager App

Merge lp://staging/~elopio/ubuntu-filemanager-app/clean_context_menu_tests into lp://staging/ubuntu-filemanager-app

clean_context_menu_tests
Merge into trunk

Proposed by Leo Arias on 2014-06-11

Status:	Merged
Approved by:	Nicholas Skaggs on 2014-06-18
Approved revision:	205
Merged at revision:	210
Proposed branch:	lp://staging/~elopio/ubuntu-filemanager-app/clean_context_menu_tests
Merge into:	lp://staging/ubuntu-filemanager-app
Diff against target:	766 lines (+306/-178) 6 files modified debian/control (+2/-1) tests/autopilot/filemanager/emulators.py (+86/-24) tests/autopilot/filemanager/fixture_setup.py (+78/-0) tests/autopilot/filemanager/tests/__init__.py (+42/-10) tests/autopilot/filemanager/tests/test_context_menu.py (+83/-0) tests/autopilot/filemanager/tests/test_filemanager.py (+15/-143)
To merge this branch:	bzr merge lp://staging/~elopio/ubuntu-filemanager-app/clean_context_menu_tests
Related bugs:	Link a bug report
Related blueprints:	Automated tests backlog for Utopic (High)

Reviewer	Review Type	Date Requested	Status
Nicholas Skaggs (community)		2014-06-11	Approve on 2014-06-18
Ubuntu Phone Apps Jenkins Bot	continuous-integration		Approve on 2014-06-18
Review via email: mp+222888@code.staging.launchpad.net

Commit message

Refactored the first group of context menu tests.

Description of the change

I removed some clean ups unnecessary as we are working on a temp folder that will be deleted. I also removed the two tests that check the context popover is opened, because we are doing that check on open_actions.

Revision history for this message

Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote on 2014-06-11:

PASSED: Continuous integration, rev:201
http://91.189.93.70:8080/job/ubuntu-filemanager-app-ci/251/
Executed test runs:
    SUCCESS: http://91.189.93.70:8080/job/generic-mediumtests-utopic/508
        deb: http://91.189.93.70:8080/job/generic-mediumtests-utopic/508/artifact/work/output/*zip*/output.zip
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-filemanager-app-utopic-amd64-ci/49

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/ubuntu-filemanager-app-ci/251/rebuild

review: Approve (continuous-integration)

Revision history for this message

Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote on 2014-06-11:

PASSED: Continuous integration, rev:203
http://91.189.93.70:8080/job/ubuntu-filemanager-app-ci/252/
Executed test runs:
    SUCCESS: http://91.189.93.70:8080/job/generic-mediumtests-utopic/509
        deb: http://91.189.93.70:8080/job/generic-mediumtests-utopic/509/artifact/work/output/*zip*/output.zip
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-filemanager-app-utopic-amd64-ci/50

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/ubuntu-filemanager-app-ci/252/rebuild

review: Approve (continuous-integration)

Revision history for this message

Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote on 2014-06-12:

PASSED: Continuous integration, rev:204
http://91.189.93.70:8080/job/ubuntu-filemanager-app-ci/253/
Executed test runs:
    SUCCESS: http://91.189.93.70:8080/job/generic-mediumtests-utopic/510
        deb: http://91.189.93.70:8080/job/generic-mediumtests-utopic/510/artifact/work/output/*zip*/output.zip
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-filemanager-app-utopic-amd64-ci/51

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/ubuntu-filemanager-app-ci/253/rebuild

review: Approve (continuous-integration)

Revision history for this message

Nicholas Skaggs (nskaggs) wrote on 2014-06-17:

_copy_xauthority_file needs a little tweaking.. ~ is better expanded as os.environ.get('HOME'). I seem to remember a bug we found where this didn't expand properly.

Also, getting this error running on the device. Rebasing with trunk didn't seem to change anything;

17:09:09.133 ERROR testresult:46 - traceback: {{{
Traceback (most recent call last):
File "/home/phablet/autopilot/filemanager/tests/test_context_menu.py", line 41, in test_rename_directory
files_and_folders = self.get_current_directory_files_and_folders()
File "/home/phablet/autopilot/filemanager/tests/test_context_menu.py", line 27, in get_current_directory_files_and_folders
return folder_list_page.get_files_and_folders()
File "/home/phablet/autopilot/filemanager/emulators.py", line 216, in get_files_and_folders
raise NotImplementedError()
NotImplementedError
}}}