selenium-simple-test

Merge lp://staging/~elopio/selenium-simple-test/download into lp://staging/selenium-simple-test

  1. download
  2. Merge into trunk
Proposed by Leo Arias
Status: Work in progress
Proposed branch: lp://staging/~elopio/selenium-simple-test/download
Merge into: lp://staging/selenium-simple-test
Diff against target: 72 lines (+47/-4)
1 file modified
src/sst/actions.py (+47/-4)
To merge this branch: bzr merge lp://staging/~elopio/selenium-simple-test/download
Reviewer Review Type Date Requested Status
Vincent Ladeuil (community) Needs Information
Corey Goldberg Pending
Review via email: mp+118999@code.staging.launchpad.net

Commit message

Added the download function.

Description of the change

Added the download function.
This branch lacks the self test.

To post a comment you must log in.
Revision history for this message
Vincent Ladeuil (vila) wrote :

> This branch lacks the self test.

Or several.

Just reading quickly:

68 + if 'Content-Dispoisition' in info

'Content-Disposition' would have been caught by tests ;)

But more generally, sst is about delegating that kind of stuff to the browser (there are *many* weird cases you don't want to even try to support that are already properly handled there).

You can even write tests using 'file:///' urls

review: Needs Fixing
Reply
Revision history for this message
Vincent Ladeuil (vila) wrote :

@Leo: ping

Are you still working on this proposal (mark it wip) or not (mark it rejected) ?

;)

review: Needs Information
Reply
Revision history for this message
Leo Arias (elopio) wrote :

Marked as work in progress.
It's currently not needed, but it will be in the future. However, it should probably be moved to the test that's requiring it, not necessarily on SST.

Reply

Unmerged revisions

291. By Leo Arias

Typo.

290. By Leo Arias

Typo.

289. By Leo Arias

Added the name from the content disposition.

288. By Leo Arias

Merged with trunk.

287. By Leo Arias

Cleaned the download function a little.

286. By Leo Arias

Typo.

285. By Leo Arias

Fixed the call to urlibopen.

284. By Leo Arias

Removed the print statements.

283. By Leo Arias

Fixed the get_cookies call.

282. By Leo Arias

Fixed typo.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches