Click Update Manager

Merge lp://staging/~elopio/click-update-manager/fix1234379-autopilot_tests into lp://staging/click-update-manager

  1. fix1234379-autopilot_tests
  2. Merge into trunk
Proposed by Leo Arias
Status: Merged
Approved by: Leo Arias
Approved revision: 34
Merged at revision: 33
Proposed branch: lp://staging/~elopio/click-update-manager/fix1234379-autopilot_tests
Merge into: lp://staging/click-update-manager
Diff against target: 273 lines (+93/-135)
3 files modified
tests/autopilot/click_update_manager/__init__.py (+85/-117)
tests/autopilot/click_update_manager/main/__init__.py (+0/-1)
tests/autopilot/click_update_manager/test_main.py (+8/-17)
To merge this branch: bzr merge lp://staging/~elopio/click-update-manager/fix1234379-autopilot_tests
Reviewer Review Type Date Requested Status
Corey Goldberg (community) Approve
PS Jenkins bot (community) continuous-integration Approve
Diego Sarmentero (community) Approve
Ubuntu One hackers Pending
Review via email: mp+189245@code.staging.launchpad.net

Commit message

Cleaned the autopilot test cases.

To post a comment you must log in.
lp://staging/~elopio/click-update-manager/fix1234379-autopilot_tests updated
32. By Leo Arias

Fixed pyflakes.

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:32
http://jenkins.qa.ubuntu.com/job/click-update-manager-ci/28/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/click-update-manager-saucy-amd64-ci/28
    SUCCESS: http://jenkins.qa.ubuntu.com/job/click-update-manager-saucy-armhf-ci/28

Click here to trigger a rebuild:
http://s-jenkins:8080/job/click-update-manager-ci/28/rebuild

review: Approve (continuous-integration)
Revision history for this message
Diego Sarmentero (diegosarmentero) wrote :

+1

review: Approve
lp://staging/~elopio/click-update-manager/fix1234379-autopilot_tests updated
33. By Leo Arias

Fixed the install desktop path.

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:33
http://10.97.0.26:8080/job/click-update-manager-ci/32/
Executed test runs:
    SUCCESS: http://10.97.0.26:8080/job/click-update-manager-saucy-amd64-ci/32
    SUCCESS: http://10.97.0.26:8080/job/click-update-manager-saucy-armhf-ci/32

Click here to trigger a rebuild:
http://10.97.0.26:8080/job/click-update-manager-ci/32/rebuild

review: Approve (continuous-integration)
Revision history for this message
Corey Goldberg (coreygoldberg) wrote :

looks very good.
one small nitpick:

197 + self.app = self.launch_test_application(
198 + '/usr/lib/' + arch + '/qt5/bin/qmlscene',
199 + "-I" + _get_module_include_path(),

... should probably use os.path.join() instead of appending strings so it matches the rest of code style.

lp://staging/~elopio/click-update-manager/fix1234379-autopilot_tests updated
34. By Leo Arias

Used os.path.join for the qmlscene path, as suggested by cgoldberg.

Revision history for this message
Corey Goldberg (coreygoldberg) wrote :

LGTM.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: