Merge lp://staging/~elfy/ubuntu-manual-tests/minorchanges into lp://staging/ubuntu-manual-tests
Proposed by
Elfy
| Status: | Merged | ||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Merged at revision: | 264 | ||||||||||||||||||||
| Proposed branch: | lp://staging/~elfy/ubuntu-manual-tests/minorchanges | ||||||||||||||||||||
| Merge into: | lp://staging/ubuntu-manual-tests | ||||||||||||||||||||
| Diff against target: |
226 lines (+30/-54) 5 files modified
testcases/packages/1509_Abiword (+8/-10) testcases/packages/1559_Catfish (+7/-29) testcases/packages/1588_gThumb (+4/-4) testcases/packages/1604_Gnome Calculator (+10/-10) testcases/packages/1627_Mugshot (+1/-1) |
||||||||||||||||||||
| To merge this branch: | bzr merge lp://staging/~elfy/ubuntu-manual-tests/minorchanges | ||||||||||||||||||||
| Related bugs: |
|
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| David Pires | Approve | ||
|
Review via email:
|
|||
Description of the change
Changes to testcases in Xubuntu Applications testsuite
To post a comment you must log in.
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
Ely, there are a few corrections that have to be made to the Abiword, Catfish and gThumb tests.
1 -> In the 1509 Abiword test, there's a typo at line 5. You have <dd>Abiword opens succesfully</dd> and it should be <dd>Abiword opens successfully</dd>
2 -> In the 1559 Catfish test, there's a tag not closed at line 46. You have <dt>Open a terminal from the menu</dt and it should be <dt>Open a terminal from the menu</dt>
The indentation at line 47 needs 4 more spaces to the right
Line 64 needs to be corrected as the folder icon is placed at the left of the search term box, you have <dt>Click on Folder icon to right of search term box</dt> and it should be <dt>Click on Folder icon to left of search term box</dt>
One thing I think you're missing is the use of the <code></code> tags. In my opinion they should be added to lines 13, 15, 48 and 50. See below:
Line 13:
You have <dt>Type cd Desktop and enter</dt> and it should be <dt>Type <code>cd Desktop</code> and enter</dt>
Line 15:
You have <dt>Type touch test Test and enter</dt> and it should be <dt>Type <code>touch test Test</code> and enter</dt>
Line 48:
You have <dt>Type cd Desktop and enter</dt> and it should be <dt>Type <code>touch test Test</code> and enter</dt>
Line 50:
You have <dt>Type touch .test and enter</dt> and it should be <dt>Type <code>touch .test</code> and enter</dt>
3 -> In the 1588 gThumb test, there's two typos, one at line 113 and another at line171.
Line 113:
You have <dd>A slideshow presentation of the image files in the currente directory starts</dd> and it should be <dd>A slideshow presentation of the image files in the current directory starts</dd>
Line 171:
You have <dd>Depending on the action choosed, the bookmark is renamed and/or relocated, deleted or gThumb positions itself on the selected bookmark</dd> and it should be <dd>Depending on the action chosen, the bookmark is renamed and/or relocated, deleted or gThumb positions itself on the selected bookmark</dd>
Other than those, I think they're OK to be merged. Thank you.